fix: BX-1358 #1407
Merged
fix: BX-1358 #1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estebanmino
requested review from
greg-schrammel,
brunobar79,
derHowie and
BrodyHughes
|
Here's the packed extension for this build: |
BrodyHughes
approved these changes
Mar 15, 2024
derHowie
approved these changes
Mar 18, 2024
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
greg-schrammel
pushed a commit
that referenced
this pull request
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes BX-1358
Figma link (if any):
What changed (plus any additional context for devs)
change introduced here #1003 was making the black color to adjust to a gray since the contract with dark theme was low, which makes sense but here we're using it with avatar color as background
so i added a flag
respectColorto skip that color treatment if is presentScreen recordings / screenshots
What to test