Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BX-1397] feat: include POAPs #1469

Merged
merged 8 commits into from
Apr 11, 2024
Merged

[BX-1397] feat: include POAPs #1469

merged 8 commits into from
Apr 11, 2024

Conversation

derHowie
Copy link
Member

@derHowie derHowie commented Apr 5, 2024

What changed (plus any additional context for devs)

Including gnosis chain in NFT requests. Mirroring the app's display and removed links to OpenSea for POAPs. Changed block explorer links to direct to https://collectors.poap.xyz/drop/${dropId}.

Screen recordings / screenshots

Screen Shot 2024-04-05 at 4 55 57 PM Screen Shot 2024-04-05 at 4 56 26 PM Screen Shot 2024-04-05 at 4 56 40 PM Screen Shot 2024-04-05 at 4 56 56 PM

What to test

Ensure that POAPs appear and UI looks alright.

Copy link

linear bot commented Apr 5, 2024

Copy link

github-actions bot commented Apr 5, 2024

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-52213de59ab9113157903882d9e11f337ebff32d.zip
screenshots

Copy link

github-actions bot commented Apr 8, 2024

Here's the packed extension for this build:
rainbowbx-a39d526c7d402ede7fa7d049725e3bfff63b05c0.zip

Copy link
Member

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my poaps are visible now, two questions

  • should we allow send? i see the send button in the dropdown menu
  • opensea link seems broken, does it exist?

@derHowie
Copy link
Member Author

derHowie commented Apr 9, 2024

my poaps are visible now, two questions

  • should we allow send? i see the send button in the dropdown menu
  • opensea link seems broken, does it exist?

@estebanmino No, these should have been removed. Good call. I changed the dropdown and context menus to exclude these for POAPs.

Copy link

github-actions bot commented Apr 9, 2024

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-6a59196834d7cfe4c8e8f8cf92751d2ea0c2df40.zip
screenshots

Copy link
Member

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-4ba04143150d5ced6be1288d2b3b643c1b01c43e.zip
screenshots

Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-1b43f1a62c03515c4bd040c5cb394bdc8f733614.zip
screenshots

Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-2013bc7bd5259db30669de9b51832c0604a72854.zip
screenshots

Copy link

Here's the packed extension for this build:
rainbowbx-2013bc7bd5259db30669de9b51832c0604a72854.zip

@derHowie derHowie added this pull request to the merge queue Apr 11, 2024
Merged via the queue into master with commit ae26bc8 Apr 11, 2024
17 checks passed
@derHowie derHowie deleted the @chris/include-poaps branch April 11, 2024 01:20
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-ae26bc847e46d908de8e96fdb861233581dbdd05.zip

derHowie added a commit that referenced this pull request Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants