Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] update network explainer to include all networks. #1490

Merged
merged 9 commits into from
Apr 18, 2024

Conversation

BrodyHughes
Copy link
Member

Fixes BX-1413

What changed (plus any additional context for devs)

  • our network explainers were only covering about 6 different networks.
  • my changes make it support any network
  • there is general text for L2 networks that use ChainName this should just support any official rainbow networks by default
  • Polygon, BSC, and Avalanche have separate copies as sidechains / L1s
  • I added a catch all copy for custom networks. Will want product input on the wording.

Screen recordings / screenshots

Screen.Recording.2024-04-11.at.4.23.36.PM.mov

What to test

  • do all the chain explainers work?

Copy link

linear bot commented Apr 11, 2024

Copy link

Here's the packed extension for this build:
rainbowbx-6e4d8e9e91666320ed161898cb0131657e16a969.zip

Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-370e038bb6e500eb14fd3cf3d170f7574bf1bcc3.zip
screenshots

Copy link
Member

@derHowie derHowie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticing in your video that the first word is not capitalized in a few cases. Seeing 'polygon' and 'blast'

@BrodyHughes
Copy link
Member Author

Noticing in your video that the first word is not capitalized in a few cases. Seeing 'polygon' and 'blast'

fixed this

Copy link

Here's the packed extension for this build:
rainbowbx-79fde61f40ac3ac5318a5443917812e4c3ab3aa1.zip

@derHowie derHowie self-requested a review April 17, 2024 21:52
Copy link
Member

@derHowie derHowie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix, lgtm

Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-b32fd0cd888af242b70f542512ef5858a8b3e736.zip

@BrodyHughes BrodyHughes added this pull request to the merge queue Apr 18, 2024
Copy link

Here's the packed extension for this build:
rainbowbx-91b2459f69c01b86c74672b26d92edc8648a62b1.zip

Merged via the queue into master with commit f8705ca Apr 18, 2024
17 checks passed
@BrodyHughes BrodyHughes deleted the brody/network-explainer branch April 18, 2024 05:34
Copy link

Here's the packed extension for this build:
rainbowbx-f8705ca9fbfcb5e07070c54bb1dd7e65e6824cb9.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants