-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add zora again if is missing #1496
Conversation
Here's the packed extension for this build: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this has the same issue I tried to solve with this #1470
if the last time the user opened the bx this store was at version 2, the only migration that's happening is the one adding support for blast
I think we can fix this by using
- if (version === 4)
+ if (version <= 4)
or merging that util
@greg-schrammel i'm down to merfge that, is already approved |
60bd732
to
d875b5d
Compare
Here's the packed extension for this build: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested from the previous release (with existing Zora RPC) and worked for that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got my app into a broken state (Zora RPC gone) and this fixed it! nice work.
Screen.Recording.2024-04-17.at.2.12.55.PM.mov
@estebanmino Added to the merge queue after our testing FYII |
Here's the packed extension for this build: |
Fixes BX-1420
Figma link (if any):
What changed (plus any additional context for devs)
adding zora back to the state if is missing for these users
details and POW video in ticket
Screen recordings / screenshots
What to test