Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add zora again if is missing #1496

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Conversation

estebanmino
Copy link
Member

Fixes BX-1420
Figma link (if any):

What changed (plus any additional context for devs)

adding zora back to the state if is missing for these users

details and POW video in ticket

Screen recordings / screenshots

What to test

Copy link

linear bot commented Apr 15, 2024

@estebanmino estebanmino marked this pull request as ready for review April 15, 2024 18:12
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-41c73e377e8bdd113905de320ae62b88c3a4e9fa.zip
screenshots

Copy link
Contributor

@greg-schrammel greg-schrammel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has the same issue I tried to solve with this #1470

if the last time the user opened the bx this store was at version 2, the only migration that's happening is the one adding support for blast

I think we can fix this by using

- if (version === 4)
+ if (version <= 4)

or merging that util

@estebanmino
Copy link
Member Author

@greg-schrammel i'm down to merfge that, is already approved

Copy link

Here's the packed extension for this build:
rainbowbx-61f38d5464f2130484304b2f42f7ab439cb67b4c.zip

Copy link
Contributor

@DanielSinclair DanielSinclair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested from the previous release (with existing Zora RPC) and worked for that

Copy link
Member

@BrodyHughes BrodyHughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got my app into a broken state (Zora RPC gone) and this fixed it! nice work.

Screen.Recording.2024-04-17.at.2.12.55.PM.mov

@DanielSinclair DanielSinclair added this pull request to the merge queue Apr 17, 2024
@DanielSinclair
Copy link
Contributor

@estebanmino Added to the merge queue after our testing FYII

Merged via the queue into master with commit 6ad736e Apr 17, 2024
17 checks passed
@DanielSinclair DanielSinclair deleted the @esteban/add-zora-if-missing branch April 17, 2024 19:38
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-6ad736e0922768ef1e964b517b539ab35ee905b9.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants