Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

degen issues #1518

Merged
merged 4 commits into from
Apr 25, 2024
Merged

degen issues #1518

merged 4 commits into from
Apr 25, 2024

Conversation

estebanmino
Copy link
Member

Fixes BX-1427
Figma link (if any):

What changed (plus any additional context for devs)

deatils in ticket

  • degen not being active by default fixed here cfff9c5
  • avoid rpc duplication fixed here f8ac1b7 we were just adding a new rpc without checking the old rpc is the same than the new one
  • adding a migration to add degen rpc in case is missing 17952ad

Screen recordings / screenshots

What to test

Copy link

linear bot commented Apr 24, 2024

@estebanmino estebanmino marked this pull request as ready for review April 24, 2024 19:30
Copy link

Here's the packed extension for this build:
rainbowbx-959e0cd66229d0813536242be6bbf109fa419eb1.zip

Copy link
Contributor

@DanielSinclair DanielSinclair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't have a wallet in a broken state to test against, but migration succeeded for me and Degen Chain works as expected

@DanielSinclair
Copy link
Contributor

cc @BrodyHughes do you have a broken dev wallet in any of these states that you can test?
Screenshot 2024-04-22 135325
Screenshot 2024-04-22 at 4 15 08 PM
Screenshot 2024-04-23 at 3 48 05 PM

@DanielSinclair DanielSinclair added this pull request to the merge queue Apr 25, 2024
Merged via the queue into master with commit 0c76c32 Apr 25, 2024
17 checks passed
@DanielSinclair DanielSinclair deleted the @esteban/aaaaaa branch April 25, 2024 03:48
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-0c76c327ccd2398d7210064330a3e0a193dd14b6.zip

@DanielSinclair
Copy link
Contributor

@estebanmino Released this internally, and tested with the existing state of my internal build, and it looks like two instance of the chains are added, but the RPC list is empty. These screenshots are the same before and after the upgrade
Screenshot 2024-04-24 at 11 25 30 PM
Screenshot 2024-04-24 at 11 25 35 PM

@DanielSinclair
Copy link
Contributor

DanielSinclair commented Apr 25, 2024

Dumped local state to see if we can diagnose that way:

rainbow.zustand.customRPCs:

{
    "state": {
        "customChains": {},
        "customRPCs": {}
    },
    "version": 0
}

rainbow.zustand.userChains:

{
    "state": {
        "userChains": {
            "1": true,
            "10": true,
            "56": true,
            "137": true,
            "8453": true,
            "42161": true,
            "43114": true,
            "81457": true,
            "7777777": true,
            "666666666": true
        },
        "userChainsOrder": [1, 10, 56, 137, 8453, 42161, 43114, 81457, 7777777, 666666666]
    },
    "version": 4
}

rainbow.zustand.rainbowChains:

REDACTED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants