Disable HW on firefox #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
derHowie
reviewed
Aug 31, 2023
src/core/languages/en_US.json
Outdated
| @@ -1031,7 +1031,8 @@ | |||
| "alert": { | |||
| "ok": "Ok", | |||
| "wallet_watching_mode": "This wallet is currently in 'Watching' mode", | |||
| "coming_soon": "Coming Soon!" | |||
| "coming_soon": "Coming Soon!", | |||
| "no_hw_ff": "Harware wallets are not supported on Firefox. Try a different Browser like Chrome or Brave." | |||
There was a problem hiding this comment.
"Harware" -> "Hardware"
"Browser" -> "browser"
brunobar79
commented
Aug 31, 2023
derHowie
approved these changes
Aug 31, 2023
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
estebanmino
approved these changes
Aug 31, 2023
|
Here's the packed extension for this build: |
greg-schrammel
pushed a commit
that referenced
this pull request
Sep 4, 2023
greg-schrammel
pushed a commit
that referenced
this pull request
Sep 6, 2023
|
What was the reason for disabling firefox hardware wallet support? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes BX-####
Figma link (if any):
What changed (plus any additional context for devs)
Disable HW on firefox including e2e. Showing an alert, see below.
Screen recordings / screenshots
What to test
Final checklist
yarn build).