Disable prop types rule #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estrattonbailey
approved these changes
Sep 1, 2022
|
Will merge and integrate today, thanks for this! |
estrattonbailey
added a commit
that referenced
this pull request
Sep 1, 2022
estrattonbailey
added a commit
that referenced
this pull request
Sep 1, 2022
feat: bump release to include #93
github-actions bot
pushed a commit
that referenced
this pull request
Sep 1, 2022
# [4.2.0](v4.1.0...v4.2.0) (2022-09-01) ### Features * bump release to include [#93](#93) ([50c5833](50c5833))
|
🎉 This PR is included in version 4.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't use prop-types and it adds no value at all just creates a visual noise for developers.
Also it spams with lots of warning when you run
yarn lintso you can easily miss the important things.We have no plans of using prop-types.
So this rule makes no sense.