Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tsconfig noImplicitAny #26

Merged
merged 1 commit into from
Nov 10, 2022
Merged

fix: tsconfig noImplicitAny #26

merged 1 commit into from
Nov 10, 2022

Conversation

alexandre-abrioux
Copy link
Contributor

@alexandre-abrioux alexandre-abrioux commented Feb 8, 2022

While contributing to this repository I encountered a Typescript error when trying to use the library:

> yarn start

TSError: Unable to compile TypeScript:
src/index.ts:2:21 - error TS7016: Could not find a declaration file for module 'moving-averages'. 'fee-suggestions/node_modules/moving-averages/lib/index.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/moving-averages` if it exists or add a new declaration (.d.ts) file containing `declare module 'moving-averages';`

I found out here that changing noImplicitAny to false could fix this issue, and it did.

Edit: This is a patch that works but setting noImplicitAny to false is not a good solution for the long term. Feel free to close this PR. I would suggest migrating from moving-averages to moving-average (without the "s") that supports Typescript: https://www.npmjs.com/package/moving-average

@welps welps requested a review from estebanmino March 5, 2022 14:57
@welps welps merged commit 958d5d5 into rainbow-me:main Nov 10, 2022
@alexandre-abrioux alexandre-abrioux deleted the tsconfig-any branch March 10, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants