Skip to content

Commit

Permalink
Improve GIF playback speed on ProMotion devices
Browse files Browse the repository at this point in the history
Bumps react-native-fast-image's SDWebImage dependency to include this change: SDWebImage/SDWebImage#3280

There's still an issue where if a GIF is in a sheet and you're dragging the sheet, the speed changes while dragging, but otherwise this fixes the issue
  • Loading branch information
christianbaroni authored and skylarbarrera committed May 4, 2022
1 parent 4047061 commit fe27e4f
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 6 deletions.
12 changes: 6 additions & 6 deletions ios/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,7 @@ PODS:
- React
- RNFastImage (8.5.11):
- React-Core
- SDWebImage (~> 5.11.1)
- SDWebImage (~> 5.12.5)
- SDWebImageWebPCoder (~> 0.8.4)
- RNFBApp (14.7.0):
- Firebase/CoreOnly (= 8.14.0)
Expand Down Expand Up @@ -590,9 +590,9 @@ PODS:
- React-Core
- RNTextSize (4.0.0-rc.1):
- React
- SDWebImage (5.11.1):
- SDWebImage/Core (= 5.11.1)
- SDWebImage/Core (5.11.1)
- SDWebImage (5.12.5):
- SDWebImage/Core (= 5.12.5)
- SDWebImage/Core (5.12.5)
- SDWebImageWebPCoder (0.8.4):
- libwebp (~> 1.0)
- SDWebImage/Core (~> 5.10)
Expand Down Expand Up @@ -1076,7 +1076,7 @@ SPEC CHECKSUMS:
RNCMaskedView: c298b644a10c0c142055b3ae24d83879ecb13ccd
RNDeviceInfo: 6f20764111df002b4484f90cbe0a861be29bcc6c
RNExitApp: c4e052df2568b43bec8a37c7cd61194d4cfee2c3
RNFastImage: 1f2cab428712a4baaf78d6169eaec7f622556dd7
RNFastImage: 945abf54742505d790d9024d230c69b1e866bc88
RNFBApp: 097a31d372b3db15b41c7a1a5c429433b0609e12
RNFBCrashlytics: 4ec9aae1a1dbb6572d095417392483bec82b07bb
RNFBMessaging: 06a7a73883f3f43da61507dbfcf4db2245c22869
Expand All @@ -1097,7 +1097,7 @@ SPEC CHECKSUMS:
RNStoreReview: 62d6afd7c37db711a594bbffca6b0ea3a812b7a8
RNSVG: 91e9ee67766408d08cb08f5bd80cd57c9d2a6691
RNTextSize: 21c94a67819fbf2c358a219bf6d251e3be9e5f29
SDWebImage: a7f831e1a65eb5e285e3fb046a23fcfbf08e696d
SDWebImage: 0905f1b7760fc8ac4198cae0036600d67478751e
SDWebImageWebPCoder: f93010f3f6c031e2f8fb3081ca4ee6966c539815
Sentry: 0c5cd63d714187b4a39c331c1f0eb04ba7868341
Shimmer: c5374be1c2b0c9e292fb05b339a513cf291cac86
Expand Down
12 changes: 12 additions & 0 deletions patches/react-native-fast-image+8.5.11.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
diff --git a/node_modules/react-native-fast-image/RNFastImage.podspec b/node_modules/react-native-fast-image/RNFastImage.podspec
index db0fada..54d8d5b 100644
--- a/node_modules/react-native-fast-image/RNFastImage.podspec
+++ b/node_modules/react-native-fast-image/RNFastImage.podspec
@@ -16,6 +16,6 @@ Pod::Spec.new do |s|
s.source_files = "ios/**/*.{h,m}"

s.dependency 'React-Core'
- s.dependency 'SDWebImage', '~> 5.11.1'
+ s.dependency 'SDWebImage', '~> 5.12.5'
s.dependency 'SDWebImageWebPCoder', '~> 0.8.4'
end

0 comments on commit fe27e4f

Please sign in to comment.