Followup on removing last chart price overrides #4506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinchung
force-pushed
the
@jin/followup-last-chart-price
branch
from
fe29023
to
4fbf335
Compare
jinchung
force-pushed
the
@jin/remove-last-chart-price-override
branch
from
944a8d9
to
86ab846
Compare
APP-301 Remove the override of the last price in chart data
Commits can be read in order. We had an override of the last price point in chart data to match it with the "current price" of an asset. However, sometimes the last price point we have is stale data, and it caused weird inconsistent issues with charts. This PR removes that manual override and just uses the default chart data as is. In the course of doing this PR, I noticed quite a few other params that were unused or unnecessary. In order to test this PR, charts should behave as expected, and we should no longer see any stale price chart data or weird lines on charts. |
jinchung
requested review from
skylarbarrera,
estrattonbailey,
jkadamczyk and
benisgold
skylarbarrera
approved these changes
Jan 6, 2023
| fetchingCharts: false, | ||
| fetchingCharts2: false, |
salman-rb
approved these changes
Jan 6, 2023
jinchung
force-pushed
the
@jin/followup-last-chart-price
branch
from
4fbf335
to
bef893a
Compare
Base automatically changed from
@jin/remove-last-chart-price-override
to
develop
January 7, 2023 01:54
The relevant hooks and components use chartType passed along in params when necessary - they do not read the redux state for it.
This is just to help simplify as there is another useChartData from the reanimated chart package.
jinchung
force-pushed
the
@jin/followup-last-chart-price
branch
from
bef893a
to
bbdd3d5
Compare
estrattonbailey
added a commit
that referenced
this pull request
Jan 17, 2023
…cations-onboarding-improvements * origin/develop: (102 commits) Ledger: Match "Looking for devices" screen to spec + animated device image (#4222) feat: add logger.log, send log/warn to Sentry (#4544) Remove generic asset fallback (#4527) Remove optimism explorer redux (#4524) Fix L2 transaction badges in transactions history (#4539) Change copy from View Contact to Edit Contact to avoid confusion (#4538) Fix ENS transactions bug, missing network parameter in RainbowTransaction (#4543) Update original asset address (#4540) Update remote config (#4535) rc v1.8.6 fixes (#4523) ledger: init ledgerSigner + logger context (#4515) load the correct provider (#4536) audit: ignore debug (#4531) feat: add walletconnect debug context, use new logger (#4514) ledger: holdToAuthorizeButton (#4516) feat: align approval sheet navigation params (#4517) chore: remove com.polidea.reactnativeble.BlePackage import (#4518) Remove transaction details playground from dev menu (#4519) Add scroll enabled back and disable status icon for short phones (#4521) Followup on removing last chart price overrides (#4506) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on Fixes APP-301