Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HOCs #1596

Merged
merged 9 commits into from
Jan 18, 2021
Merged

Remove HOCs #1596

merged 9 commits into from
Jan 18, 2021

Conversation

jinchung
Copy link
Member

@jinchung jinchung commented Jan 16, 2021

  • Removed additional hocs that were only being used in singular places.
  • Also includes a bug fix where withOpenBalances and withOpenSavings hocs were reading from the wrong redux location.
  • Moved asset selectors that were in the hoc directory (moved them to the helpers directory where the other selectors are currently located.)

While removing, tested data was still being passed through appropriately.

For general testing:

  • Main wallet asset list opening of small balances / pinning / unpinning should work as expected
  • Selecting currencies from settings should behave as expected
  • Assets list in wallet and swap asset lists should look normal

@jinchung jinchung requested review from a team and skylarbarrera January 16, 2021 01:53
Copy link
Contributor

@mikedemarais mikedemarais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doooooope

looks good to me

thanks for doing this @jinchung

Copy link
Contributor

@osdnk osdnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go 🐎

Copy link
Contributor

@skylarbarrera skylarbarrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍳

@jinchung jinchung force-pushed the @jin/remove-unused-hocs-part-2 branch from 5318db6 to 4c3f592 Compare January 18, 2021 20:06
@skylarbarrera skylarbarrera merged commit 7d922ab into develop Jan 18, 2021
@jinchung jinchung deleted the @jin/remove-unused-hocs-part-2 branch January 27, 2021 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants