Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean-up code #1672

Merged
merged 3 commits into from
Feb 5, 2021
Merged

clean-up code #1672

merged 3 commits into from
Feb 5, 2021

Conversation

osdnk
Copy link
Contributor

@osdnk osdnk commented Feb 3, 2021

remove recompact, get rid of withThemeContext where possible

@osdnk osdnk requested a review from a team February 3, 2021 15:35
mikedemarais
mikedemarais approved these changes Feb 4, 2021
View reviewed changes
Copy link
Contributor

@mikedemarais mikedemarais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great

thanks for doing this

@osdnk osdnk merged commit 8832409 into develop Feb 5, 2021
@osdnk osdnk deleted the @osdnk/clean-up branch February 5, 2021 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikedemarais mikedemarais mikedemarais approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@osdnk @mikedemarais