Set up codepush #3109

osdnk · 2022-03-28T18:05:58Z

Fixes RNBW-2900

What changed (plus any additional context for devs)

This is pretty straightforward. Some people got access to appcenter.ms. Also, I added iOS variable to CI.

https://app.bitrise.io/app/1e59de65aba81dde/workflow_editor#!/workflows?workflow_id=workflow_tests

Android keys are here: https://github.com/rainbow-me/rainbow-env/pull/33

I add 1067309 to the audit allowlist. This is: GHSA-gff7-g5r8-mg8m
And this is fixed by bumping plist to 3.0.5 what @tchayen a few days ago already did wollardj/simple-plist#62 by resolutions.

PoW (screenshots / screen recordings)

https://streamable.com/9189co
https://streamable.com/i7cac6

Dev checklist for QA: what to test

You can test by pulling, building release version, making a change, running:

appcenter codepush release-react -a osdnk/rainbow-ios-codepush  -d Staging
appcenter codepush release-react -a osdnk/rainbow-android-codepush  -d Staging

and observing if changes got propagated

You should have keys for Staging (iOS is already in info.plist), Android is in linked PR

linear · 2022-03-28T18:06:00Z

RNBW-2900 Research about codepush

microsoft/react-native-code-push#1986

This is available for some time and will be beneficial for hot fixes.

brunobar79

LGTM! Would be great if we can add clear steps on notion about how to do a staging a prod release

ios/Rainbow/Info.plist

package.json

terrysahaidak · 2022-03-29T07:16:18Z

Not sure if you'd like to do it in this PR, but we need to show somewhere the coduepush build version as well as add a "sync codepush build" button for tests and qa

osdnk · 2022-03-29T07:20:42Z

I don't think we need the button. Regarding versions, bumping in package.json is not enough?

terrysahaidak · 2022-03-29T07:25:27Z

I don't think we need the button. Regarding versions, bumping in package.json is not enough?

how to make sure during the QA or support that the app runs a specific codepushed bundle version?

the button is for the dev section. I used to have such a thing in other projects and it was helpful.

osdnk · 2022-03-29T07:26:30Z

@terrysahaidak isn't it enough to rerun the app and check the version in settings?

osdnk · 2022-03-29T07:32:25Z

I mean, i can add the button. I will do this. I just wonder if this is truly necessarily

terrysahaidak · 2022-03-29T07:35:24Z

@terrysahaidak isn't it enough to rerun the app and check the version in settings?

in reality we are gonna have different builds for Android and iOS. only if it's not a problem.

osdnk · 2022-03-29T07:39:31Z

Hm, what does it mean in this context? I don't get the connection with button

osdnk · 2022-03-29T10:08:56Z

After a private conversation with @terrysahaidak I used his idea:
https://streamable.com/ri8qmi
Here is the v number.

Also, here is an example sentry log: https://sentry.io/organizations/rainbow-me/releases/1.6.9%20(1)%20(CP%20v6)/?environment=LocalRelease&project=1855565

osdnk · 2022-03-29T10:54:04Z

Here is the notion doc: https://www.notion.so/rainbowdotme/Codepush-magic-8c56506281be429e8079d881785e2955

osdnk · 2022-03-29T10:55:58Z

src/components/settings-menu/DevSection.js

+              installMode: codePush.InstallMode.IMMEDIATE,
+            });
+
+            const resultString = Object.entries(codePush.syncStatus).find(


result is a number, I want to make it a proper string

tchayen · 2022-03-29T11:20:32Z

How about using word 'Build' instead of 'CP' when displaying the version?

We will know what it means and for users it's just enough info in case they ever (need to) see it.

src/hooks/useAppVersion.js

tchayen

Of course it looks good. I just have tiny comments about code style and wording but nothing that would matter much.

osdnk · 2022-03-29T12:22:32Z

@tchayen I renamed to update

src/hooks/useSendFeedback.js

src/components/settings-menu/DevSection.js

terrysahaidak

Overall looks OK. I don't like how everything is spread all around the app. But it's not in the scope of this PR.

…dnk/set-up-codepush

This reverts commit 2defc4b.

This reverts commit cc7bfe1.

* Revert "Set up codepush (#3109)" This reverts commit 2defc4b. * rename RapExchangeActionParameters * lang useOnAvatarPress * lang NFTBriefTokenInfoRow * lang RegistrationCover * lang watch * lang edit profile * tests * remove unused e2e * Revert "Revert "Set up codepush (#3109)"" This reverts commit cc7bfe1. * use helpers * swipe up dev settings * swipe up dev settings * all passing

* ENS Registration: Upload Avatar/Cover (#2967) * WIP * WIP * WIP * Spinner.js -> .tsx * revert * Polish * Fix lint errors * Fix android * PR review * ENS Registration: Choose NFT Avatar (#2969) * WIP * WIP * WIP * Spinner.js -> .tsx * revert * WIP * Polish * WIP * WIP * Fix lint errors * useMemo * WIP * rename * Merge * PR review * remove ios changes * @benisgold/ens i18n (#2983) i18n * @benisgold/apply accent color (#2989) * applied accent color to confirm registration button * applied accent color to gas speed button * @esteban/registration watcher (#2978) * add flag to featureFlaf hook * export ens addresses from references ens * actions rm * ENS_DOMAIN to helper * EnsRegistrationActionTypes create * disable profiles by default * profiles enabled * fix ens action dispatch * WIP UI * use hardhat by default REVERT * refactor rap action types * refactor action execution * hook handler handling commit tx * handle 60 secs wait * add register hook in handler * handler working as expected * sending raps correctly skipping multicall * Revert "use hardhat by default REVERT" This reverts commit fa0e8e30a3f801afb8f721c97a798a3df619a312. * use block confirmation time * secs in a year util * types * Revert "Revert "use hardhat by default REVERT"" This reverts commit 839f301be7946ab49aff3a86246ac23221f64ea5. * more types * better type names * lint * fix watch tx confirmation step * simulate tx confirmation wait * simulate tx confirmation wait REVERT * hardcode initial multicall estimation * persistence working * useENSPendingRegistrations * save register with config tx hash in registration * remove hardhat hacks to watch txs * Revert "Revert "Revert "use hardhat by default REVERT""" This reverts commit d0c13d721dbb48ab5bc9b3e5b8d29ff30a37304d. * entities * Update src/hooks/useENSPendingRegistrations.tsx Co-authored-by: moxey.eth <jakemoxey@gmail.com> * type * fix type * key value object * merge lint Co-authored-by: moxey.eth <jakemoxey@gmail.com> * Update redux on input change (#2994) * Profiles: Edit ENS Profile (part 1) (#2984) * WIP * WIP * wip * WIP * WIP * Fix lint issues * Refactor * Fixes * fix debug layout * Fix * @esteban/handle records transactions (#2991) * add flag to featureFlaf hook * export ens addresses from references ens * actions rm * ENS_DOMAIN to helper * EnsRegistrationActionTypes create * disable profiles by default * profiles enabled * fix ens action dispatch * WIP UI * use hardhat by default REVERT * refactor rap action types * refactor action execution * hook handler handling commit tx * handle 60 secs wait * add register hook in handler * handler working as expected * sending raps correctly skipping multicall * Revert "use hardhat by default REVERT" This reverts commit fa0e8e30a3f801afb8f721c97a798a3df619a312. * use block confirmation time * secs in a year util * types * Revert "Revert "use hardhat by default REVERT"" This reverts commit 839f301be7946ab49aff3a86246ac23221f64ea5. * more types * better type names * lint * fix watch tx confirmation step * simulate tx confirmation wait * simulate tx confirmation wait REVERT * hardcode initial multicall estimation * persistence working * useENSPendingRegistrations * save register with config tx hash in registration * remove hardhat hacks to watch txs * Revert "Revert "Revert "use hardhat by default REVERT""" This reverts commit d0c13d721dbb48ab5bc9b3e5b8d29ff30a37304d. * entities * Update src/hooks/useENSPendingRegistrations.tsx Co-authored-by: moxey.eth <jakemoxey@gmail.com> * type * fix type * key value object * merge lint * enable multicall dummy gas estimate again * HARDHAT HARDCODED REVERT * dont send multicall if the records arent valid * use records from state * use multicall estimation on estimated network fee * fix get rent price * send setText if only one text is added to the records * revert some dev settings * use confirmedAt * Revert "HARDHAT HARDCODED REVERT" This reverts commit 775fa3645cb00927b250ac523fa20c90bfa3f22c. Co-authored-by: moxey.eth <jakemoxey@gmail.com> * restrict watching wallets (#2992) * Use changedRecords for commit phase (#3002) * @benisgold/fix bio android (#2995) - Fixed size of input box for bio record on android - Make input boxes not scrollable on android * Fix edit ENS for .eth that have no records (#3006) * Profiles: ENS Expanded State (#2997) * add ens fab REVERT * init route * check registration * use Box * wip * Tweaks * omit GradientInput * register ENS feature flag (#2874) * flag * RegisterENSFlowNavigator * Profiles: ENS Search Input (#2888) * Add Cover component; height prop to Box; text/heading hooks * Add space * Export text/heading hooks * wip * WIP * WIP * Fixes * refactor * memo * WIP * Refactor * Tweaks * remove skia * revert * revert * revert * tweaks * Revert * Refactor gradients * refactor * Refactor * Fix dark mode gradients * add contents (#2896) * Update SearchInputGradientBackground.tsx * Android beta link in Readme (#2894) * polygon nfts (#2893) * ui: add l2 disclaimer + explainer * ui: dark disclaimer * polygon/v2 parser * types, v2 api url and change parsers * refactor nft fetching to handle multiple networks * rm log * block -> allow * filter out bad nfts * stop fetching on error * dont show price info for non mainnet nfts * yarn audit * network type * explainer - disclaimer * check current address * nft block explorer * dont check prices for poaps and polygon * Cleanup of should stop fetching param and typescript * Fix: include network in nft block explorer function * Fix linting issues Co-authored-by: jinchung <jin.chung17@gmail.com> * Fix Co-authored-by: Esteban Miño <efmino@uc.cl> Co-authored-by: Terry Sahaidak <tasssik@gmail.com> Co-authored-by: Skylar Barrera <skylar.barrera@gmail.com> Co-authored-by: jinchung <jin.chung17@gmail.com> * Inline > Row * Profiles: ENS Registration Action Buttons (#2892) * Add Cover component; height prop to Box; text/heading hooks * Add space * Export text/heading hooks * wip * WIP * WIP * Fixes * refactor * memo * WIP * Refactor * Tweaks * remove skia * revert * revert * revert * tweaks * Revert * WIP * Refactor gradients * refactor * Refactor * Add action buttons for ENS registration * Fix dark mode gradients * Inline > Row * ens registration search result indicators (#2876) added indicators that shows whether an ens name is available or taken, how much it costs, and when it expires * @esteban/ens utils (#2911) * ensdomains ensjs types * add ens abis * add some utils methods, resolver, available and rentPrice * rm enjs * useENS hook * comments * add js-sha3 * add base registrar implementation * add getNameExpires * only use registrationDate from subgraph * Update src/helpers/ens.ts Co-authored-by: moxey.eth <jakemoxey@gmail.com> * change name to useENSRegistration * move queries inside hook * reorg methods and hook * move formatters to hook * get everything from hook * dont use all methods if not needed, by availability * handle hook status * everything in the same state in hook * nameIsValid * rent price per year in fiat * add formatRentPrice * toLocaleDateString instead * isInvalidLength * useQuery FTW Co-authored-by: moxey.eth <jakemoxey@gmail.com> * Profiles: Add inline validation for ENS search (#2918) * Add inline validation for ENS search * refactor * can not -> cannot * Update * Update * Update RegisterEnsSheet.js * Update tests * Profiles: Register ENS navigation foundation (#2913) * Add ENS Navigation * Remove screens * Fix conflicts * Rename component * Fix keyboard issue * @benisgold/additional indicators (#2917) * created indicators for registration fee and ens age * formatted expiration date and rent price * @esteban/ens state manager (#2935) * add redux ensRegistration * add some redux methods * include kens app keys as enum * rm unused code * @benisgold/profile screen nav buttons (#2937) add profile screen nav buttons * @esteban/network fee estimations (#2924) * add dummy txs * create utility methods for each ens registration methods that we'll use * WIP estimates for multicall * estimate gas for all txs * cleaner code * estimateENSSetNameGasLimit * rename ENSRegistrationTransactionType * rename ownerAddress * use estimateENSTransactionGaslimit to manage estimations * convertAmountAndPriceToNativeDisplay skip decimals * estimateENSRegistrationGasLimit * get and format estimatedTotalCost * better code * estimated costs * useENSRegistrationEstimations * bignumber for rentprice * makeCommitmentWithConfig instead of makeCommitment * useENSRegistrationCosts * rename some ens search sheet vars * use rent price to trigger useQuery * estimateENSTransactionGasLimit * export helpers * lint * Update src/hooks/useENSRegistrationCosts.ts Co-authored-by: moxey.eth <jakemoxey@gmail.com> * Update src/hooks/useENSRegistrationCosts.ts Co-authored-by: moxey.eth <jakemoxey@gmail.com> * Update src/hooks/useENSRegistrationCosts.ts Co-authored-by: moxey.eth <jakemoxey@gmail.com> * lint from latest commits * running now Co-authored-by: moxey.eth <jakemoxey@gmail.com> * Profiles: Create ENS profile form (#2938) * Add ENS Navigation * Remove screens * Fix conflicts * Rename component * WIP * Fix keyboard issue * WIP * WIP * WIP * FIX * Fix android * Fix issues * Fixes * Profiles: ENS Registration – Review Costs UI (#2947) * WIP * Polish * Add tests for addDisplay * Refactor * Fix stale time on useENSRegistration * Fix lint * Refactor * Add Hold to Buy and hint text * Fix issue where keyboard toggle wasn't showing on android (#2952) * @benisgold/ens header (#2945) * added placeholder cover photo and messed about with slack sheet top padding * avatar placeholder * added ens name header and partial implementation of accent color based on ens avatar * isInvalid is broken * add Skip button and adjust gradients * added loading network fees text * fix invisible TintButtons on android * fix android sheet handle * fix rebase and adjust layout * adjust hide keyboard button positioning and add correct colors * check if form is empty * more color * lint * small fixes * RQ v3 * Profiles: ENS navigation fixes (#2957) * added placeholder cover photo and messed about with slack sheet top padding * avatar placeholder * added ens name header and partial implementation of accent color based on ens avatar * isInvalid is broken * add Skip button and adjust gradients * added loading network fees text * fix invisible TintButtons on android * fix android sheet handle * fix rebase and adjust layout * adjust hide keyboard button positioning and add correct colors * check if form is empty * more color * lint * Fix ens nav * Fix * Fix * Refactor * Make android cool * Fixes * PR review * Move const up Co-authored-by: Ben Goldberg <bengoldberg@rainbow.me> * @benisgold/confirm screen header (#2956) * added dividers and header to confirm screen * apply drop shadows * lint * Fix Co-authored-by: moxey.eth <jakemoxey@gmail.com> * @esteban/txs raps (#2953) * create raps and actions * create actions for raps with correct types * add gas button to confirmation screen * estimateENSRegisterSetRecordsAndNameGasLimit * create raps for commit and register/multicall/setName txs * make registrations redux by account and name * use redux currentRegistrationName in state * update useEnsProfile to new format * WIP saving commit tx params in state * final tweeks to txs * auto review comments * onlt commit tx in confirm screen * more auto review comments * lint raptypes * rm some comments * some review comments * Update src/entities/ensRegistration.ts Co-authored-by: moxey.eth <jakemoxey@gmail.com> * Fix ENS profile form * block sending commit tx * align confirmation and gas speed buttons * remove waitENS boilerplate Co-authored-by: moxey.eth <jakemoxey@gmail.com> * added cover/avatar placeholders (#2961) Co-authored-by: moxey.eth <jakemoxey@gmail.com> * Profiles: Polish avatar/cover & add loading skeletons (#2958) * added placeholder cover photo and messed about with slack sheet top padding * avatar placeholder * added ens name header and partial implementation of accent color based on ens avatar * isInvalid is broken * add Skip button and adjust gradients * added loading network fees text * fix invisible TintButtons on android * fix android sheet handle * fix rebase and adjust layout * adjust hide keyboard button positioning and add correct colors * check if form is empty * more color * lint * Fix ENS navigation * progress * Fix ens nav * Fix * Fix * Refactor * Make android cool * Fixes * PR review * Move const up * More polish * Fix * More polish Co-authored-by: Ben Goldberg <bengoldberg@rainbow.me> * @esteban/ens profiles review comments (#2968) * add flag to featureFlaf hook * export ens addresses from references ens * actions rm * ENS_DOMAIN to helper * EnsRegistrationActionTypes create * disable profiles by default * fix ens action dispatch * Update src/handlers/ens.ts Co-authored-by: Bruno Barbieri <brunobar79@gmail.com> * ENS Registration: Upload Avatar/Cover (#2967) * WIP * WIP * WIP * Spinner.js -> .tsx * revert * Polish * Fix lint errors * Fix android * PR review * @esteban/more comments review (#2975) * add cover to multicall estimation * remove js-sha3 * replace action names for consts * timeunit secs in a year * remove await in dispatch * WIP * WIP * Remove useDebounceString (#2980) * Register ENS: Inline style optimisation & PR comments (#2977) * Optimise inline styles * PR comments * ENS Registration: Choose NFT Avatar (#2969) * WIP * WIP * WIP * Spinner.js -> .tsx * revert * WIP * Polish * WIP * WIP * Fix lint errors * useMemo * WIP * rename * Merge * PR review * remove ios changes * wip * WIP * WIP * Fix lint issues * WIP * @benisgold/ens i18n (#2983) i18n * Refactor * Revert ios/ * Fixes * @benisgold/apply accent color (#2989) * applied accent color to confirm registration button * applied accent color to gas speed button * @esteban/registration watcher (#2978) * add flag to featureFlaf hook * export ens addresses from references ens * actions rm * ENS_DOMAIN to helper * EnsRegistrationActionTypes create * disable profiles by default * profiles enabled * fix ens action dispatch * WIP UI * use hardhat by default REVERT * refactor rap action types * refactor action execution * hook handler handling commit tx * handle 60 secs wait * add register hook in handler * handler working as expected * sending raps correctly skipping multicall * Revert "use hardhat by default REVERT" This reverts commit fa0e8e30a3f801afb8f721c97a798a3df619a312. * use block confirmation time * secs in a year util * types * Revert "Revert "use hardhat by default REVERT"" This reverts commit 839f301be7946ab49aff3a86246ac23221f64ea5. * more types * better type names * lint * fix watch tx confirmation step * simulate tx confirmation wait * simulate tx confirmation wait REVERT * hardcode initial multicall estimation * persistence working * useENSPendingRegistrations * save register with config tx hash in registration * remove hardhat hacks to watch txs * Revert "Revert "Revert "use hardhat by default REVERT""" This reverts commit d0c13d721dbb48ab5bc9b3e5b8d29ff30a37304d. * entities * Update src/hooks/useENSPendingRegistrations.tsx Co-authored-by: moxey.eth <jakemoxey@gmail.com> * type * fix type * key value object * merge lint Co-authored-by: moxey.eth <jakemoxey@gmail.com> * Update redux on input change (#2994) * refactor unique token expanded state to be more composable * WIP * Profiles: Edit ENS Profile (part 1) (#2984) * WIP * WIP * wip * WIP * WIP * Fix lint issues * Refactor * Fixes * fix debug layout * Fix * some serious alpha happening here * Fix edit ENS for .eth that have no records * wip * WIP * WIP * Refactor * Add loading states * i18n * Fix * PR review * revert * Add explainers Co-authored-by: Esteban Miño <efmino@uc.cl> Co-authored-by: Terry Sahaidak <tasssik@gmail.com> Co-authored-by: Skylar Barrera <skylar.barrera@gmail.com> Co-authored-by: jinchung <jin.chung17@gmail.com> Co-authored-by: Ben Goldberg <bengoldberg@rainbow.me> Co-authored-by: Bruno Barbieri <brunobar79@gmail.com> * @esteban/edit profiles to transactions (#3004) * HARDHAT REVERT THIS * add edit step to handler * fix records updates * use from addres to estimate multicall * estimate gas depending on multicall or set text * cleanup * createSetRecordsENSRap * some cleanup * registration steps cleanup * Revert "HARDHAT REVERT THIS" This reverts commit 7ac16439ec97702bb31d861146687462893c03ae. * some clean up * clean up txs handler * way cleaner code * add formatENSActionParams * revert some last changes * useFocusEffect * Fixes for dark mode (#3025) * allow ENS edition only for controller (#3010) * iis ens owner checks * is owner from hook * fix lint * fetch reverse record (#3031) * Profiles: ENS Registration – Add field validation (#3019) * add ens fab REVERT * init route * check registration * use Box * wip * Tweaks * omit GradientInput * register ENS feature flag (#2874) * flag * RegisterENSFlowNavigator * Profiles: ENS Search Input (#2888) * Add Cover component; height prop to Box; text/heading hooks * Add space * Export text/heading hooks * wip * WIP * WIP * Fixes * refactor * memo * WIP * Refactor * Tweaks * remove skia * revert * revert * revert * tweaks * Revert * Refactor gradients * refactor * Refactor * Fix dark mode gradients * add contents (#2896) * Update SearchInputGradientBackground.tsx * Android beta link in Readme (#2894) * polygon nfts (#2893) * ui: add l2 disclaimer + explainer * ui: dark disclaimer * polygon/v2 parser * types, v2 api url and change parsers * refactor nft fetching to handle multiple networks * rm log * block -> allow * filter out bad nfts * stop fetching on error * dont show price info for non mainnet nfts * yarn audit * network type * explainer - disclaimer * check current address * nft block explorer * dont check prices for poaps and polygon * Cleanup of should stop fetching param and typescript * Fix: include network in nft block explorer function * Fix linting issues Co-authored-by: jinchung <jin.chung17@gmail.com> * Fix Co-authored-by: Esteban Miño <efmino@uc.cl> Co-authored-by: Terry Sahaidak <tasssik@gmail.com> Co-authored-by: Skylar Barrera <skylar.barrera@gmail.com> Co-authored-by: jinchung <jin.chung17@gmail.com> * Inline > Row * Profiles: ENS Registration Action Buttons (#2892) * Add Cover component; height prop to Box; text/heading hooks * Add space * Export text/heading hooks * wip * WIP * WIP * Fixes * refactor * memo * WIP * Refactor * Tweaks * remove skia * revert * revert * revert * tweaks * Revert * WIP * Refactor gradients * refactor * Refactor * Add action buttons for ENS registration * Fix dark mode gradients * Inline > Row * ens registration search result indicators (#2876) added indicators that shows whether an ens name is available or taken, how much it costs, and when it expires * @esteban/ens utils (#2911) * ensdomains ensjs types * add ens abis * add some utils methods, resolver, available and rentPrice * rm enjs * useENS hook * comments * add js-sha3 * add base registrar implementation * add getNameExpires * only use registrationDate from subgraph * Update src/helpers/ens.ts Co-authored-by: moxey.eth <jakemoxey@gmail.com> * change name to useENSRegistration * move queries inside hook * reorg methods and hook * move formatters to hook * get everything from hook * dont use all methods if not needed, by availability * handle hook status * everything in the same state in hook * nameIsValid * rent price per year in fiat * add formatRentPrice * toLocaleDateString instead * isInvalidLength * useQuery FTW Co-authored-by: moxey.eth <jakemoxey@gmail.com> * Profiles: Add inline validation for ENS search (#2918) * Add inline validation for ENS search * refactor * can not -> cannot * Update * Update * Update RegisterEnsSheet.js * Update tests * Profiles: Register ENS navigation foundation (#2913) * Add ENS Navigation * Remove screens * Fix conflicts * Rename component * Fix keyboard issue * @benisgold/additional indicators (#2917) * created indicators for registration fee and ens age * formatted expiration date and rent price * @esteban/ens state manager (#2935) * add redux ensRegistration * add some redux methods * include kens app keys as enum * rm unused code * @benisgold/profile screen nav buttons (#2937) add profile screen nav buttons * @esteban/network fee estimations (#2924) * add dummy txs * create utility methods for each ens registration methods that we'll use * WIP estimates for multicall * estimate gas for all txs * cleaner code * estimateENSSetNameGasLimit * rename ENSRegistrationTransactionType * rename ownerAddress * use estimateENSTransactionGaslimit to manage estimations * convertAmountAndPriceToNativeDisplay skip decimals * estimateENSRegistrationGasLimit * get and format estimatedTotalCost * better code * estimated costs * useENSRegistrationEstimations * bignumber for rentprice * makeCommitmentWithConfig instead of makeCommitment * useENSRegistrationCosts * rename some ens search sheet vars * use rent price to trigger useQuery * estimateENSTransactionGasLimit * export helpers * lint * Update src/hooks/useENSRegistrationCosts.ts Co-authored-by: moxey.eth <jakemoxey@gmail.com> * Update src/hooks/useENSRegistrationCosts.ts Co-authored-by: moxey.eth <jakemoxey@gmail.com> * Update src/hooks/useENSRegistrationCosts.ts Co-authored-by: moxey.eth <jakemoxey@gmail.com> * lint from latest commits * running now Co-authored-by: moxey.eth <jakemoxey@gmail.com> * Profiles: Create ENS profile form (#2938) * Add ENS Navigation * Remove screens * Fix conflicts * Rename component * WIP * Fix keyboard issue * WIP * WIP * WIP * FIX * Fix android * Fix issues * Fixes * Profiles: ENS Registration – Review Costs UI (#2947) * WIP * Polish * Add tests for addDisplay * Refactor * Fix stale time on useENSRegistration * Fix lint * Refactor * Add Hold to Buy and hint text * Fix issue where keyboard toggle wasn't showing on android (#2952) * @benisgold/ens header (#2945) * added placeholder cover photo and messed about with slack sheet top padding * avatar placeholder * added ens name header and partial implementation of accent color based on ens avatar * isInvalid is broken * add Skip button and adjust gradients * added loading network fees text * fix invisible TintButtons on android * fix android sheet handle * fix rebase and adjust layout * adjust hide keyboard button positioning and add correct colors * check if form is empty * more color * lint * small fixes * RQ v3 * Profiles: ENS navigation fixes (#2957) * added placeholder cover photo and messed about with slack sheet top padding * avatar placeholder * added ens name header and partial implementation of accent color based on ens avatar * isInvalid is broken * add Skip button and adjust gradients * added loading network fees text * fix invisible TintButtons on android * fix android sheet handle * fix rebase and adjust layout * adjust hide keyboard button positioning and add correct colors * check if form is empty * more color * lint * Fix ens nav * Fix * Fix * Refactor * Make android cool * Fixes * PR review * Move const up Co-authored-by: Ben Goldberg <bengoldberg@rainbow.me> * @benisgold/confirm screen header (#2956) * added dividers and header to confirm screen * apply drop shadows * lint * Fix Co-authored-by: moxey.eth <jakemoxey@gmail.com> * @esteban/txs raps (#2953) * create raps and actions * create actions for raps with correct types * add gas button to confirmation screen * estimateENSRegisterSetRecordsAndNameGasLimit * create raps for commit and register/multicall/setName txs * make registrations redux by account and name * use redux currentRegistrationName in state * update useEnsProfile to new format * WIP saving commit tx params in state * final tweeks to txs * auto review comments * onlt commit tx in confirm screen * more auto review comments * lint raptypes * rm some comments * some review comments * Update src/entities/ensRegistration.ts Co-authored-by: moxey.eth <jakemoxey@gmail.com> * Fix ENS profile form * block sending commit tx * align confirmation and gas speed buttons * remove waitENS boilerplate Co-authored-by: moxey.eth <jakemoxey@gmail.com> * added cover/avatar placeholders (#2961) Co-authored-by: moxey.eth <jakemoxey@gmail.com> * Profiles: Polish avatar/cover & add loading skeletons (#2958) * added placeholder cover photo and messed about with slack sheet top padding * avatar placeholder * added ens name header and partial implementation of accent color based on ens avatar * isInvalid is broken * add Skip button and adjust gradients * added loading network fees text * fix invisible TintButtons on android * fix android sheet handle * fix rebase and adjust layout * adjust hide keyboard button positioning and add correct colors * check if form is empty * more color * lint * Fix ENS navigation * progress * Fix ens nav * Fix * Fix * Refactor * Make android cool * Fixes * PR review * Move const up * More polish * Fix * More polish Co-authored-by: Ben Goldberg <bengoldberg@rainbow.me> * @esteban/ens profiles review comments (#2968) * add flag to featureFlaf hook * export ens addresses from references ens * actions rm * ENS_DOMAIN to helper * EnsRegistrationActionTypes create * disable profiles by default * fix ens action dispatch * Update src/handlers/ens.ts Co-authored-by: Bruno Barbieri <brunobar79@gmail.com> * ENS Registration: Upload Avatar/Cover (#2967) * WIP * WIP * WIP * Spinner.js -> .tsx * revert * Polish * Fix lint errors * Fix android * PR review * @esteban/more comments review (#2975) * add cover to multicall estimation * remove js-sha3 * replace action names for consts * timeunit secs in a year * remove await in dispatch * WIP * WIP * Remove useDebounceString (#2980) * Register ENS: Inline style optimisation & PR comments (#2977) * Optimise inline styles * PR comments * ENS Registration: Choose NFT Avatar (#2969) * WIP * WIP * WIP * Spinner.js -> .tsx * revert * WIP * Polish * WIP * WIP * Fix lint errors * useMemo * WIP * rename * Merge * PR review * remove ios changes * wip * WIP * WIP * Fix lint issues * WIP * @benisgold/ens i18n (#2983) i18n * Refactor * Revert ios/ * Fixes * @benisgold/apply accent color (#2989) * applied accent color to confirm registration button * applied accent color to gas speed button * @esteban/registration watcher (#2978) * add flag to featureFlaf hook * export ens addresses from references ens * actions rm * ENS_DOMAIN to helper * EnsRegistrationActionTypes create * disable profiles by default * profiles enabled * fix ens action dispatch * WIP UI * use hardhat by default REVERT * refactor rap action types * refactor action execution * hook handler handling commit tx * handle 60 secs wait * add register hook in handler * handler working as expected * sending raps correctly skipping multicall * Revert "use hardhat by default REVERT" This reverts commit fa0e8e30a3f801afb8f721c97a798a3df619a312. * use block confirmation time * secs in a year util * types * Revert "Revert "use hardhat by default REVERT"" This reverts commit 839f301be7946ab49aff3a86246ac23221f64ea5. * more types * better type names * lint * fix watch tx confirmation step * simulate tx confirmation wait * simulate tx confirmation wait REVERT * hardcode initial multicall estimation * persistence working * useENSPendingRegistrations * save register with config tx hash in registration * remove hardhat hacks to watch txs * Revert "Revert "Revert "use hardhat by default REVERT""" This reverts commit d0c13d721dbb48ab5bc9b3e5b8d29ff30a37304d. * entities * Update src/hooks/useENSPendingRegistrations.tsx Co-authored-by: moxey.eth <jakemoxey@gmail.com> * type * fix type * key value object * merge lint Co-authored-by: moxey.eth <jakemoxey@gmail.com> * Update redux on input change (#2994) * refactor unique token expanded state to be more composable * WIP * Profiles: Edit ENS Profile (part 1) (#2984) * WIP * WIP * wip * WIP * WIP * Fix lint issues * Refactor * Fixes * fix debug layout * Fix * some serious alpha happening here * Fix edit ENS for .eth that have no records * wip * WIP * WIP * Refactor * Add loading states * i18n * Fix * PR review * revert * Add explainers * Add field validation * revert ios * Fix * fix eslint * Add startsWith * Fix error Co-authored-by: Esteban Miño <efmino@uc.cl> Co-authored-by: Terry Sahaidak <tasssik@gmail.com> Co-authored-by: Skylar Barrera <skylar.barrera@gmail.com> Co-authored-by: jinchung <jin.chung17@gmail.com> Co-authored-by: Ben Goldberg <bengoldberg@rainbow.me> Co-authored-by: Bruno Barbieri <brunobar79@gmail.com> * profiles: two step flow screens & reverse records (#3033) * HARDHAT REVERT * SIMULATE TX CONFIRMATION WAIT REVERT * step titles * estimated cost in eth * reorder components * reorder sheet * dummy ui * content and action by step * switcher * sendReverseRecord boolean * some cleanup * edit dummy step * move UI to components * handle reverse record * enable button when step gas limit is available * Revert "SIMULATE TX CONFIRMATION WAIT REVERT" This reverts commit c71da12f69fbfc85613265f4fcc76e8f4ab25cc3. * Revert "HARDHAT REVERT" This reverts commit 970258c69466582d7f9e8bc87b562bf29e83ef55. * use box aligned items to center * profiles: handle resolver when editing profile (#3035) * use accent color for gas speed button and custom gas (#3036) * use accent color for gas speed button and custom gas * use accent color * Profiles: Profile Sheet (without asset list) (#3026) * add ens fab REVERT * init route * check registration * use Box * wip * Tweaks * omit GradientInput * register ENS feature flag (#2874) * flag * RegisterENSFlowNavigator * Profiles: ENS Search Input (#2888) * Add Cover component; height prop to Box; text/heading hooks * Add space * Export text/heading hooks * wip * WIP * WIP * Fixes * refactor * memo * WIP * Refactor * Tweaks * remove skia * revert * revert * revert * tweaks * Revert * Refactor gradients * refactor * Refactor * Fix dark mode gradients * add contents (#2896) * Update SearchInputGradientBackground.tsx * Android beta link in Readme (#2894) * polygon nfts (#2893) * ui: add l2 disclaimer + explainer * ui: dark disclaimer * polygon/v2 parser * types, v2 api url and change parsers * refactor nft fetching to handle multiple networks * rm log * block -> allow * filter out bad nfts * stop fetching on error * dont show price info for non mainnet nfts * yarn audit * network type * explainer - disclaimer * check current address * nft block explorer * dont check prices for poaps and polygon * Cleanup of should stop fetching param and typescript * Fix: include network in nft block explorer function * Fix linting issues Co-authored-by: jinchung <jin.chung17@gmail.com> * Fix Co-authored-by: Esteban Miño <efmino@uc.cl> Co-authored-by: Terry Sahaidak <tasssik@gmail.com> Co-authored-by: Skylar Barrera <skylar.barrera@gmail.com> Co-authored-by: jinchung <jin.chung17@gmail.com> * Inline > Row * Profiles: ENS Registration Action Buttons (#2892) * Add Cover component; height prop to Box; text/heading hooks * Add space * Export text/heading hooks * wip * WIP * WIP * Fixes * refactor * memo * WIP * Refactor * Tweaks * remove skia * revert * revert * revert * tweaks * Revert * WIP * Refactor gradients * refactor * Refactor * Add action buttons for ENS registration * Fix dark mode gradients * Inline > Row * ens registration search result indicators (#2876) added indicators that shows whether an ens name is available or taken, how much it costs, and when it expires * @esteban/ens utils (#2911) * ensdomains ensjs types * add ens abis * add some utils methods, resolver, available and rentPrice * rm enjs * useENS hook * comments * add js-sha3 * add base registrar implementation * add getNameExpires * only use registrationDate from subgraph * Update src/helpers/ens.ts Co-authored-by: moxey.eth <jakemoxey@gmail.com> * change name to useENSRegistration * move queries inside hook * reorg methods and hook * move formatters to hook * get everything from hook * dont use all methods if not needed, by availability * handle hook status * everything in the same state in hook * nameIsValid * rent price per year in fiat * add formatRentPrice * toLocaleDateString instead * isInvalidLength * useQuery FTW Co-authored-by: moxey.eth <jakemoxey@gmail.com> * Profiles: Add inline validation for ENS search (#2918) * Add inline validation for ENS search * refactor * can not -> cannot * Update * Update * Update RegisterEnsSheet.js * Update tests * Profiles: Register ENS navigation foundation (#2913) * Add ENS Navigation * Remove screens * Fix conflicts * Rename component * Fix keyboard issue * @benisgold/additional indicators (#2917) * created indicators for registration fee and ens age * formatted expiration date and rent price * @esteban/ens state manager (#2935) * add redux ensRegistration * add some redux methods * include kens app keys as enum * rm unused code * @benisgold/profile screen nav buttons (#2937) add profile screen nav buttons * @esteban/network fee estimations (#2924) * add dummy txs * create utility methods for each ens registration methods that we'll use * WIP estimates for multicall * estimate gas for all txs * cleaner code * estimateENSSetNameGasLimit * rename ENSRegistrationTransactionType * rename ownerAddress * use estimateENSTransactionGaslimit to manage estimations * convertAmountAndPriceToNativeDisplay skip decimals * estimateENSRegistrationGasLimit * get and format estimatedTotalCost * better code * estimated costs * useENSRegistrationEstimations * bignumber for rentprice * makeCommitmentWithConfig instead of makeCommitment * useENSRegistrationCosts * rename some ens search sheet vars * use rent price to trigger useQuery * estimateENSTransactionGasLimit * export helpers * lint * Update src/hooks/useENSRegistrationCosts.ts Co-authored-by: moxey.eth <jakemoxey@gmail.com> * Update src/hooks/useENSRegistrationCosts.ts Co-authored-by: moxey.eth <jakemoxey@gmail.com> * Update src/hooks/useENSRegistrationCosts.ts Co-authored-by: moxey.eth <jakemoxey@gmail.com> * lint from latest commits * running now Co-authored-by: moxey.eth <jakemoxey@gmail.com> * Profiles: Create ENS profile form (#2938) * Add ENS Navigation * Remove screens * Fix conflicts * Rename component * WIP * Fix keyboard issue * WIP * WIP * WIP * FIX * Fix android * Fix issues * Fixes * Profiles: ENS Registration – Review Costs UI (#2947) * WIP * Polish * Add tests for addDisplay * Refactor * Fix stale time on useENSRegistration * Fix lint * Refactor * Add Hold to Buy and hint text * Fix issue where keyboard toggle wasn't showing on android (#2952) * @benisgold/ens header (#2945) * added placeholder cover photo and messed about with slack sheet top padding * avatar placeholder * added ens name header and partial implementation of accent color based on ens avatar * isInvalid is broken * add Skip button and adjust gradients * added loading network fees text * fix invisible TintButtons on android * fix android sheet handle * fix rebase and adjust layout * adjust hide keyboard button positioning and add correct colors * check if form is empty * more color * lint * small fixes * RQ v3 * Profiles: ENS navigation fixes (#2957) * added placeholder cover photo and messed about with slack sheet top padding * avatar placeholder * added ens name header and partial implementation of accent color based on ens avatar * isInvalid is broken * add Skip button and adjust gradients * added loading network fees text * fix invisible TintButtons on android * fix android sheet handle * fix rebase and adjust layout * adjust hide keyboard button positioning and add correct colors * check if form is empty * more color * lint * Fix ens nav * Fix * Fix * Refactor * Make android cool * Fixes * PR review * Move const up Co-authored-by: Ben Goldberg <bengoldberg@rainbow.me> * @benisgold/confirm screen header (#2956) * added dividers and header to confirm screen * apply drop shadows * lint * Fix Co-authored-by: moxey.eth <jakemoxey@gmail.com> * @esteban/txs raps (#2953) * create raps and actions * create actions for raps with correct types * add gas button to confirmation screen * estimateENSRegisterSetRecordsAndNameGasLimit * create raps for commit and register/multicall/setName txs * make registrations redux by account and name * use redux currentRegistrationName in state * update useEnsProfile to new format * WIP saving commit tx params in state * final tweeks to txs * auto review comments * onlt commit tx in confirm screen * more auto review comments * lint raptypes * rm some comments * some review comments * Update src/entities/ensRegistration.ts Co-authored-by: moxey.eth <jakemoxey@gmail.com> * Fix ENS profile form * block sending commit tx * align confirmation and gas speed buttons * remove waitENS boilerplate Co-authored-by: moxey.eth <jakemoxey@gmail.com> * added cover/avatar placeholders (#2961) Co-authored-by: moxey.eth <jakemoxey@gmail.com> * Profiles: Polish avatar/cover & add loading skeletons (#2958) * added placeholder cover photo and messed about with slack sheet top padding * avatar placeholder * added ens name header and partial implementation of accent color based on ens avatar * isInvalid is broken * add Skip button and adjust gradients * added loading network fees text * fix invisible TintButtons on android * fix android sheet handle * fix rebase and adjust layout * adjust hide keyboard button positioning and add correct colors * check if form is empty * more color * lint * Fix ENS navigation * progress * Fix ens nav * Fix * Fix * Refactor * Make android cool * Fixes * PR review * Move const up * More polish * Fix * More polish Co-authored-by: Ben Goldberg <bengoldberg@rainbow.me> * @esteban/ens profiles review comments (#2968) * add flag to featureFlaf hook * export ens addresses from references ens * actions rm * ENS_DOMAIN to helper * EnsRegistrationActionTypes create * disable profiles by default * fix ens action dispatch * Update src/handlers/ens.ts Co-authored-by: Bruno Barbieri <brunobar79@gmail.com> * ENS Registration: Upload Avatar/Cover (#2967) * WIP * WIP * WIP * Spinner.js -> .tsx * revert * Polish * Fix lint errors * Fix android * PR review * @esteban/more comments review (#2975) * add cover to multicall estimation * remove js-sha3 * replace action names for consts * timeunit secs in a year * remove await in dispatch * WIP * WIP * Remove useDebounceString (#2980) * Register ENS: Inline style optimisation & PR comments (#2977) * Optimise inline styles * PR comments * ENS Registration: Choose NFT Avatar (#2969) * WIP * WIP * WIP * Spinner.js -> .tsx * revert * WIP * Polish * WIP * WIP * Fix lint errors * useMemo * WIP * rename * Merge * PR review * remove ios changes * wip * WIP * WIP * Fix lint issues * WIP * @benisgold/ens i18n (#2983) i18n * Refactor * Revert ios/ * Fixes * @benisgold/apply accent color (#2989) * applied accent color to confirm registration button * applied accent color to gas speed button * @esteban/registration watcher (#2978) * add flag to featureFlaf hook * export ens addresses from references ens * actions rm * ENS_DOMAIN to helper * EnsRegistrationActionTypes create * disable profiles by default * profiles enabled * fix ens action dispatch * WIP UI * use hardhat by default REVERT * refactor rap action types * refactor action execution * hook handler handling commit tx * handle 60 secs wait * add register hook in handler * handler working as expected * sending raps correctly skipping multicall * Revert "use hardhat by default REVERT" This reverts commit fa0e8e30a3f801afb8f721c97a798a3df619a312. * use block confirmation time * secs in a year util * types * Revert "Revert "use hardhat by default REVERT"" This reverts commit 839f301be7946ab49aff3a86246ac23221f64ea5. * more types * better type names * lint * fix watch tx confirmation step * simulate tx confirmation wait * simulate tx confirmation wait REVERT * hardcode initial multicall estimation * persistence working * useENSPendingRegistrations * save register with config tx hash in registration * remove hardhat hacks to watch txs * Revert "Revert "Revert "use hardhat by default REVERT""" This reverts commit d0c13d721dbb48ab5bc9b3e5b8d29ff30a37304d. * entities * Update src/hooks/useENSPendingRegistrations.tsx Co-authored-by: moxey.eth <jakemoxey@gmail.com> * type * fix type * key value object * merge lint Co-authored-by: moxey.eth <jakemoxey@gmail.com> * Update redux on input change (#2994) * refactor unique token expanded state to be more composable * WIP * Profiles: Edit ENS Profile (part 1) (#2984) * WIP * WIP * wip * WIP * WIP * Fix lint issues * Refactor * Fixes * fix debug layout * Fix * some serious alpha happening here * Fix edit ENS for .eth that have no records * wip * WIP * WIP * Refactor * Add loading states * i18n * Fix * PR review * revert * Add explainers * WIP * WIP * WIP * Add first txn tag * WIP * WIP * WIP * PR review * Android fixes Co-authored-by: Esteban Miño <efmino@uc.cl> Co-authored-by: Terry Sahaidak <tasssik@gmail.com> Co-authored-by: Skylar Barrera <skylar.barrera@gmail.com> Co-authored-by: jinchung <jin.chung17@gmail.com> Co-authored-by: Ben Goldberg <bengoldberg@rainbow.me> Co-authored-by: Bruno Barbieri <brunobar79@gmail.com> * Profiles: ENS call-to-action banner placeholder (#3046) * WIP * Add ENS call-to-action banner * @esteban/speed up commit (#3042) * HARDHAT REVERT * SIMULATE TX CONFIRMATION WAIT REVERT * get transaction by hash * navigate to speed up screen * WaitCommitmentConfirmationContent * support for multiple commit tx hashes in the registration state * onSendTransactionCallback * replace commit has when speeding up * clean interface * Revert "SIMULATE TX CONFIRMATION WAIT REVERT" This reverts commit 32745222fd4f543c6e0910f44798f936d90a3579. * Revert "HARDHAT REVERT" This reverts commit 73fb87db998e9c901994d4a74bcee08fe62aee18. * Profiles: Defer image upload (#3047) * Defer image upload until confirm register sheet * move upload to register phase * @benisgold/fix multiline spillage (#3050) * use experimental flag for edit ens (#3063) * Crop cover photo (#3075) * Add edit button if u own ur ens (#3074) * Profiles: Profile Sheet Assets (#3052) * Init work * WIP * WIP * WIP * WIP * WIP * useENSResolveName * WIP * Refactor * Fixes Co-authored-by: osdnk <micosa97@gmail.com> * Profiles: On-chain text records data warning (#3082) * Add warning explainer for data stored on-chain * Update * Profiles: profiles ENS avatar (#3081) * on press avatar go or edit profile * pfp in tx list * useWalletENS * working * better code * add avatar url to watch profile * fix emoji picker * import wallet with image * dont update wallets if nothing changed * more on press avatar * rename useWalletENSAvatar * rm comments * bug updating wallet images * fetch images when importing * fetch images when importing if flag enabled * fix edit * isowner into useENSprofile hook * @benisgold/create profile button (#3083) create profile button Co-authored-by: Ben Goldberg <bengoldberg@rainbow.me> * Profiles: correctly estimate fees with records (#3064) * fix crash * edit action with images * editing costs * lint stuff * correctly use records to estimate network fees: : * edigt todo * fix * export debug * lint * Profiles: check enough eth for registration (#3073) * add checks * insufficient_eth * use default disaled background color * Profiles: e2e (#3051) * init flow spec * todos * go to flow * search taken name * go to records view * check price and network fee * skip with no records * assign records * start registration * start registration * wip * go to profiles screen after confirming * HARDHAT REVERT * check name from tests * Revert "HARDHAT REVERT" This reverts commit a271135853fe7116dece9cd0051d6e0276850e27. * working with banner * fix lint * fix discover e2e disabling profiles * delays * comment all tests * logs e2e * rm lint bitrise * passing * with syncronization * banner? * rm delay * checks * add some logs * remove lint * eslint-disable-next-line no-console * uncomment tests * REVERT remove flows * remove failing * remove failing * remove failing * rm some taps * try release mode * Should check review button * always visible * navigation changes * with disableSynchronization * tap by text * rm some views if testing * comment text * move action buttons to component * Use * add audit ci * not absolute when testing * remove typing * another try * move action buttons * animate: * use ENSAssignRecordsBottomActions depending of is_testing * Revert "REVERT remove flows" This reverts commit af53b7d80fd6b17d4d6f2e15bc38cc8d511e19ff. * undo bitrise changes * enable profiles flag in flow * lint * no need to modify flag now * audit ci as develop * end of line * Plug in animations Co-authored-by: Bruno Barbieri <brunobar79@gmail.com> Co-authored-by: Wojtek Witkowski <hi@wojtek.im> * Plug in animations for ENS profiles (#3091) * Add ENS Animations + fix linter * Tweak dark mode colors * Profiles: some bug fixes (#3100) * fix stuck disabled bool * fix insufficient gas label * fix estimateENSRegisterSetRecords * adjust sheet height depending on edit and avatar * lint * align speed up to bottom * add buffer to waiting period * Profiles: Handle image picker permissions (#3104) * add useImagePicker hooks * lang * use hook in avatar * update copy * lint * fix e2e (#3108) * touch * Profiles: fix addDisplay (#3111) * Profiles: fix expanded state in name with non-ASCII characters (#3112) * Profiles: go to profile on avatar press android (#3119) * open action sheet on android as well * better code * add lang * Profiles: 60 secs wait from COMMIT tx (#3113) * check 60 secs passed on a block level: * ens wait back to 60 secs again * a bit cleanerr * ready to register if IS_TESTING * check tests * add comments * promise all * getBlockMsTimestamp * Profiles: extend expiration date (#3125) * create new raps * gas estimations for new raps * estimateENSSetRecordsGasLimit rename * add gas limit and actions to action handler hook * modify regex * add edit button * pass ens name * move UI components to its own files * renew components * estimate gas for renew * estimate renew from hook * estimate gas by step * format RegistrationReviewRows * handle search ens costs * abc * mode * REGISTRATION_MODES * lint * token info buttons * create addonComponent * deeplink route to profile sheet (#3134) * @benisgold/profiles analytics (#3126) * @benisgold/fix multiline spillage (#3050) * progress * moved things around and added etherscan urls * remove comment * finished, except for user properties * profile tracking hook * got the analytics hook working * finished + lint * uncomment analytics debug line * remove this * remove unneeded analytics * Fix incorrect "Confirm Registration" placeholder – RNBW-3130 (#3141) * Profiles: (Android) Fix issue when attempting to edit ENS profile (#3142) * Fix weird edit ens issues on Android * Fix misaligned @ for twitter input; fix keyboard when warning sheet is open * Fix issue where uploading avatar and then removing a field will remove the avatar (#3143) * Fix issue where couldn't upload photos on android (#3144) * Profiles phase 2 minor review comments (#3154) * Revert "Set up codepush (#3109)" This reverts commit 2defc4bdd8c2b3556375c373ec21c05e3f5ea87a. * rename RapExchangeActionParameters * lang useOnAvatarPress * lang NFTBriefTokenInfoRow * lang RegistrationCover * lang watch * lang edit profile * tests * remove unused e2e * Revert "Revert "Set up codepush (#3109)"" This reverts commit cc7bfe1b0834bf4f9b2e774c89d0bd105a61bc18. * use helpers * swipe up dev settings * swipe up dev settings * all passing * Profiles: QA send user after editing (#3153) * send users to profile after editing * gotoprofiles * lint * Profiles: ENS Registration Intro Screen (#3121) * WIP * WIP 🤙 * WIP * Massage android * Fix * PR feedback * Profiles: Persist search value between ENS registration screens (#3156) * Persist ENS search value between screens * Use ENS_DOMAIN * make navigator lazy (#3159) * Profiles: grab accent color from avatar in edit (#3168) * Profiles: Add zoomable image preview to ENS cover photos (#3115) * zoomable cover for ens cover photo * Fix ZoomableWrapper issue on android * Fixes * Profiles: Add ability to remove ENS image records (#3155) * Add ability to remove ens photos * Update UniqueTokenExpandedState.tsx * Update UniqueTokenExpandedState.tsx * Update UniqueTokenExpandedState.tsx * Profiles: pending registrations (#3137) * fetch avatar when searching * seach up to 8 * use ens records enum * check profiles enabled * profiles enabled * initial component using hook * add avatar if defined * in progress * navigate to ens confirmation * navigate * one last step * disable switch if no gas * usePersistentDominantColorFromImage * removeRegistration * add alert when removing registration * resolve images * registrationImages * use getENSNFTAvatarUrl * ens search scrollable * DEFAULT VALUE * create mode * ens search * pending registrations * lang * empty avatar * Update src/components/ens-registration/PendingRegistrations/PendingRegistrations.tsx Co-authored-by: moxey.eth <jakemoxey@gmail.com> * lang * remove AccentColorProvider, * divider in search component Co-authored-by: moxey.eth <jakemoxey@gmail.com> * Profiles: fix onavatar press (#3166) * reorder options * press actions * fix empty image bug * methods * Profiles: adjust confirm screen in small screens (#3163) * Countdown Timer Component for ENS registration (#3158) * Countdown Timer Component for ENS registration * codeowners + change export * convert components to TS + DS * Profiles: Enable long press on duration field (#3157) * Enable long press duration * Update src/components/ens-registration/RegistrationReviewRows/RegistrationReviewRows.tsx Co-authored-by: Esteban Miño <efmino@uc.cl> * Update src/components/ens-registration/RegistrationReviewRows/RegistrationReviewRows.tsx Co-authored-by: Esteban Miño <efmino@uc.cl> * Update RegistrationReviewRows.tsx Co-authored-by: Esteban Miño <efmino@uc.cl> * Fix hourglass animation on android * address PR comments (#3171) * Profiles: improve ens search (#3120) * fetch avatar when searching * seach up to 8 * use ens records enum * check profiles enabled * profiles enabled * Profiles: Log upload image errors (#3173) * Profiles: phase two final review comments (#3176) * https://github.com/rainbow-me/rainbow/pull/2979\#discussion_r841382298 * https://github.com/rainbow-me/rainbow/pull/2979\#discussion_r844576102 * ens records lang * https://github.com/rainbow-me/rainbow/pull/2979\#discussion_r845569875 * https://github.com/rainbow-me/rainbow/pull/2979\#discussion_r845725066 * use getENSRegistrarControllerContract * tweak paddings and register screen * export and remove * Profiles: Only show ENS on-chain data warning once per user (#3170) * Save onchain data disclaimer state * Fixes * Profiles: merge ens phase 2 (#3178) * Refactor postinstall.sh to reduce code duplication and improve error handling (#3132) * Refactor postinstall.sh to reduce code duplication and improve error handling * Clean whitespace * Fix broken line break * Fix possibility to scroll with scroll indicator on unique asset image preview (#3150) Co-authored-by: Jakub Adamczyk <jakub@rainbow.me> * Remove smile emoji from label (#3160) * Profiles: adjust confirm screen in small screens (#3163) * Countdown Timer Component for ENS registration (#3158) * Countdown Timer Component for ENS registration * codeowners + change export * convert components to TS + DS * Fix hourglass animation on android * address PR comments (#3171) * exclude pin creation for isReadOnly mode (#3161) * Update audit-ci allowlist (#3175) Co-authored-by: jinchung <jin.chung17@gmail.com> * Profiles: Log upload image errors (#3173) * Profiles: phase two final review comments (#3176) * https://github.com/rainbow-me/rainbow/pull/2979\#discussion_r841382298 * https://github.com/rainbow-me/rainbow/pull/2979\#discussion_r844576102 * ens records lang * https://github.com/rainbow-me/rainbow/pull/2979\#discussion_r845569875 * https://github.com/rainbow-me/rainbow/pull/2979\#discussion_r845725066 * use getENSRegistrarControllerContract * tweak paddings and register screen * export and remove Co-authored-by: Tomasz Czajęcki <tomek.czajecki@gmail.com> Co-authored-by: Jakub Adamczyk <jkk.adamczyk@gmail.com> Co-authored-by: Jakub Adamczyk <jakub@rainbow.me> Co-authored-by: Wojtek Witkowski <hi@wojtek.im> Co-authored-by: moxey.eth <jakemoxey@gmail.com> Co-authored-by: Taras Perun <48593211+perunt@users.noreply.github.com> Co-authored-by: Bruno Barbieri <brunobar79@gmail.com> Co-authored-by: jinchung <jin.chung17@gmail.com> * Update ProfileSheet header (#3174) * Profiles: Fix keyboard inconsistencies (#3169) * fix keyboard issues * Fixes * fix android crash * Profiles: Fallback to ENS metadata API when OpenSea metadata not available yet (#3148) * Add fallback for ENS metadata * refactor * refactor * Fix * Profiles: Misc fixes (#3193) * fix keyboard issues * Fixes * fix android crash * RNBW-3263 * RNBW-3251 * Fixes * More fixes * Fix * remove hideAvatar * Update confirm sheet ui (#3197) * Profiles: additional records sheet (#3172) * add routes and additional records wip * additional records * default config sheet * add more records * TextEncoder polyfill * content hash validations * adjust height * move validation to one method * move import fast-text-encoding * typo * isPrimaryDisplayRecord * dotsButtonIsSelected * handle additional ens sheet height * lint * fix bad renaming * get fixed values with getENSRegistrationGasLimit * remove expired incomplete ens registrations (#3167) * Profiles: separate data for incomplete profiles by ens name (#3182) * Profiles: several bug fixes (#3190) * RNBW-3264 * RNBW-3263 * RNBW-3241 * RNBW-3223 * do not show empty avatar in pending registrations * RNBW-3224 * fixit * add option to extend any ens name * rename from comments * add recordKeysWithValue * Profiles: ens navigator horizontal swipe (#3205) * enable stack swipe if name available * fix is testing * Profiles: improve gas handling (#3183) * get fixed values with getENSRegistrationGasLimit * usequeries for each tx * working * estimate gas txs * use recoil to store gas validation * commit working * do not update fee on confirm * update records * step gas limit working * edit working * renew working * records * getQueryData refactor * getGasParams * get gas params * Revert "get gas params" This reverts commit b9bbc911fad2c8013581d280ee783581b7f46ff4. * Revert "getGasParams" This reverts commit 03d494848af98c3a91e46bd392f62aeb782f322d. * Revert "getQueryData refactor" This reverts commit f58e05f7fadca0c5d0df7f1d0ad3b8e5192bb875. * handle gas updates in background * use query all around * fix insufficient ETH in commit * remove gas params request * use reverse record from hook * remove recoil * merge * istesting * Profiles: 60 secs wait from COMMIT tx (#3113) * check 60 secs passed on a block level: * ens wait back to 60 secs again * a bit cleanerr * ready to register if IS_TESTING * check tests * add comments * promise all * getBlockMsTimestamp * Drop metadata.ens.domains fallback in favour of The Graph + ImgixImg (#3211) * Profiles: primary ens name explainer sheet (#3191) * ENS Profile zoomable images (#3184) * Update header * Extend ImagePreviewOverlay to work for multiple instances * remove redundant animationProgress * PR comments * Fix * Fixes * Profiles: Make ordering of action buttons match order of fields (#3212) * Make ordering of action buttons match order of fields * oops * Remove lines from gradient (#3222) * Profiles: Intro Screen polishhh (#3221) * Polish * Revert * Profiles: bio hyperlinks (#3218) * get accent color in ens confirm * add hyperlinks * recordsDescription * create own components * handling links correctly * add additional height to profile intro * fix regex * hyper link weight regular * Profiles: set primary from expanded ens (#3194) * add switch * send to primary tx confirmation * with explainer * ENS Registration Steps Progress Component (#3210) * ENS Registration Steps Progress Component * Use accentColor * isAnimatingFill change * add paddings * Revert "isAnimatingFill change" This reverts commit d1408d3eacab9fe57e9fa0577b8842951a6cc5c3. * use magic memo + padding * step Co-authored-by: Esteban Miño <efmino@uc.cl> * Profiles: intro screen updates (#3219) * use primary name if any * add context menu * lang * magnifyingglass.circle * add missing util * Profiles polish (#3225) * fetch account ens in register ens section * revalidateCollectibleInBackground only for unknown ens * remove staletime * Profiles: merge phase 2 to phase 3 (#3227) * merge * import text * add line to auditci * remove old ens * remove old ens * usePersistentDominantColorFromImage with lowResUrl * Fix ENS NFT regressions (#3230) Co-authored-by: moxey.eth <jakemoxey@gmail.com> * Profiles: fix unintended side effects of TokenInfoItem changes (#3228) * Fix zoomable images on intro screen (#3231) * Profiles: Choose NFT as cover photo (#3232) * WIP * WIP * WIP * WIP * Fixes * Profiles: Various fixes (#3239) * Fix * Fix * Profiles: improve ens discovery (#3240) * Profiles: don't normalize search input display text (#3226) * Pulsing checkmark when visible for more than 2s (#3251) * Profiles: improve costs hook (#3238) * wip * add memos * revert some changes * more cleanup * sign fix * use step in ens search costs hook * use step in ens search costs hook * Profiles: more fixes (#3252) * more fixes * use accent color when speed up correctly * enable watcher * add ens_domain * rm fix * Fix scroll issues (#3257) * Profiles: final flows e2e (#3248) * Refactor postinstall.sh to reduce code duplication and improve error handling (#3132) * Refactor postinstall.sh to reduce code duplication and improve error handling * Clean whitespace * Fix broken line break * Fix possibility to scroll with scroll indicator on unique asset image preview (#3150) Co-authored-by: Jakub Adamczyk <jakub@rainbow.me> * Remove smile emoji from label (#3160) * Profiles: adjust confirm screen in small screens (#3163) * Countdown Timer Component for ENS registration (#3158) * Countdown Timer Component for ENS registration * codeowners + change export * convert components to TS + DS * Fix hourglass animation on android * address PR comments (#3171) * exclude pin creation for isReadOnly mode (#3161) * Update audit-ci allowlist (#3175) Co-authored-by: jinchung <jin.chung17@gmail.com> * Profiles: Log upload image errors (#3173) * Fix blank charts (#3107) * Do not rerender chart if it's empty * make linter happy * Add additional memo * Profiles: phase two final review comments (#3176) * https://github.com/rainbow-me/rainbow/pull/2979\#discussion_r841382298 * https://github.com/rainbow-me/rainbow/pull/2979\#discussion_r844576102 * ens records lang * https://github.com/rainbow-me/rainbow/pull/2979\#discussion_r845569875 * https://github.com/rainbow-me/rainbow/pull/2979\#discussion_r845725066 * use getENSRegistrarControllerContract * tweak paddings and register screen * export and remove * Bump moment from 2.29.1 to 2.29.2 (#3177) * Fedora V1 (#3149) * Fix vulnerability in 2.x async (#3186) * update sendable check (#3165) * update sendable check * add erc721 to sendable nft types * Add Fedora branch indicator (#3185) * add another async vuln (#3198…

osdnk added 6 commits March 28, 2022 16:27

Staging keys

8434fb6

Configure native side

9ac16ff

Install JS deps

9bf7656

Podfile

379e920

android

759c7e3

android from env

1599535

osdnk added needs dev review Includes code review AND testing out the branch QA later merge when ready labels Mar 28, 2022

osdnk requested review from brunobar79, tchayen, terrysahaidak and skylarbarrera March 28, 2022 18:05

osdnk requested review from jinchung and removed request for tchayen and terrysahaidak March 28, 2022 18:15

brunobar79 approved these changes Mar 29, 2022

View reviewed changes

ios/Rainbow/Info.plist Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

remove appcenter other libs

3d3e1ee

osdnk added 2 commits March 29, 2022 12:14

Address Terry's feedback

9d59a4b

Fix sentry versioning

e3ae382

move CODE_PUSH_DEPLOYMENT_KEY_IOS to postinstall

d03a5dc

dist

9bfaa55

osdnk requested a review from tchayen March 29, 2022 10:55

osdnk commented Mar 29, 2022

View reviewed changes

tchayen reviewed Mar 29, 2022

View reviewed changes

src/hooks/useAppVersion.js Show resolved Hide resolved

tchayen approved these changes Mar 29, 2022

View reviewed changes

Update AppVersionStamp.js

f8641b6

tchayen reviewed Mar 29, 2022

View reviewed changes

src/hooks/useSendFeedback.js Outdated Show resolved Hide resolved

osdnk commented Mar 29, 2022

View reviewed changes

src/hooks/useSendFeedback.js Outdated Show resolved Hide resolved

Update src/hooks/useSendFeedback.js

c10e723

osdnk removed the needs dev review Includes code review AND testing out the branch label Mar 29, 2022

osdnk requested a review from terrysahaidak March 30, 2022 06:53

terrysahaidak reviewed Mar 30, 2022

View reviewed changes

src/components/settings-menu/DevSection.js Outdated Show resolved Hide resolved

terrysahaidak approved these changes Mar 30, 2022

View reviewed changes

osdnk added 3 commits March 30, 2022 13:20

useCallback

bbf1673

Merge remote-tracking branch 'origin/@osdnk/set-up-codepush' into @os…

5bb3e38

…dnk/set-up-codepush

allowlist

21ceafe

osdnk merged commit 2defc4b into develop Mar 30, 2022

osdnk deleted the @osdnk/set-up-codepush branch March 30, 2022 11:41

estebanmino added a commit that referenced this pull request Apr 5, 2022

Revert "Set up codepush (#3109)"

7ac4f2e

This reverts commit 2defc4b.

estebanmino added a commit that referenced this pull request Apr 5, 2022

Revert "Set up codepush (#3109)"

cc7bfe1

This reverts commit 2defc4b.

estebanmino added a commit that referenced this pull request Apr 5, 2022

Revert "Revert "Set up codepush (#3109)""

6754fc9

This reverts commit cc7bfe1.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set up codepush #3109

Set up codepush #3109

osdnk commented Mar 28, 2022 •

edited

linear bot commented Mar 28, 2022

brunobar79 left a comment

terrysahaidak commented Mar 29, 2022

osdnk commented Mar 29, 2022

terrysahaidak commented Mar 29, 2022

osdnk commented Mar 29, 2022

osdnk commented Mar 29, 2022

terrysahaidak commented Mar 29, 2022

osdnk commented Mar 29, 2022

osdnk commented Mar 29, 2022

osdnk commented Mar 29, 2022

osdnk Mar 29, 2022

tchayen commented Mar 29, 2022

tchayen left a comment

osdnk commented Mar 29, 2022

terrysahaidak left a comment

Set up codepush #3109

Set up codepush #3109

Conversation

osdnk commented Mar 28, 2022 • edited

What changed (plus any additional context for devs)

PoW (screenshots / screen recordings)

Dev checklist for QA: what to test

linear bot commented Mar 28, 2022

brunobar79 left a comment

Choose a reason for hiding this comment

terrysahaidak commented Mar 29, 2022

osdnk commented Mar 29, 2022

terrysahaidak commented Mar 29, 2022

osdnk commented Mar 29, 2022

osdnk commented Mar 29, 2022

terrysahaidak commented Mar 29, 2022

osdnk commented Mar 29, 2022

osdnk commented Mar 29, 2022

osdnk commented Mar 29, 2022

osdnk Mar 29, 2022

Choose a reason for hiding this comment

tchayen commented Mar 29, 2022

tchayen left a comment

Choose a reason for hiding this comment

osdnk commented Mar 29, 2022

terrysahaidak left a comment

Choose a reason for hiding this comment

osdnk commented Mar 28, 2022 •

edited