Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profiles: Address Phase 2 PR comments #3171

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Profiles: Address Phase 2 PR comments #3171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/components/asset-list/RecyclerAssetList2/core/RowRenderer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import {
SavingsHeaderExtraData,
UniswapPoolExtraData,
} from './ViewTypes';
import { UniqueAsset } from '@rainbow-me/entities';
import assertNever from '@rainbow-me/helpers/assertNever';

function CellDataProvider({
Expand Down Expand Up @@ -111,9 +110,7 @@ function rowRenderer(type: CellType, { uid }: { uid: string }) {
index,
uniqueId,
onPressUniqueToken,
} = data as NFTExtraData & {
onPressUniqueToken: (asset: UniqueAsset) => void;
};
} = data as NFTExtraData;

return (
<WrappedNFT
Expand Down
2 changes: 2 additions & 0 deletions src/components/asset-list/RecyclerAssetList2/core/ViewTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { RecyclerListView, RecyclerListViewProps } from 'recyclerlistview';
import { RecyclerListViewState } from 'recyclerlistview/dist/reactnative/core/RecyclerListView';
import { UniqueAsset } from '@rainbow-me/entities';

export enum CellType {
ASSETS_HEADER = 'ASSETS_HEADER',
Expand Down Expand Up @@ -53,6 +54,7 @@ export type NFTExtraData = {
type: CellType.NFT;
index: number;
uniqueId: string;
onPressUniqueToken?: (asset: UniqueAsset) => void;
};
export type NFTFamilyExtraData = {
type: CellType.FAMILY_HEADER;
Expand Down
7 changes: 3 additions & 4 deletions src/components/header/DiscoverHeaderButton.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,9 @@ export default function DiscoverHeaderButton() {
navigate,
]);

const onLongPress = useCallback(
() => navigate(Routes.PROFILE_SHEET, { address: 'mikedemarais.eth' }),
[navigate]
);
const onLongPress = useCallback(() => navigate(Routes.CONNECTED_DAPPS), [
navigate,
]);

const shadows = useMemo(() => DiscoverButtonShadowsFactory(colors), [colors]);

Expand Down