Improve GIF playback speed on ProMotion devices #3299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps react-native-fast-image's SDWebImage dependency to include this change: SDWebImage/SDWebImage#3280 There's still an issue where if a GIF is in a sheet and you're dragging the sheet, the speed changes while dragging, but otherwise this fixes the issue
skylarbarrera
added
the
needs dev review
RNBW-2590 animated NFTs play too fast
User alextoma.eth User reports that animated NFTs are all moving too fast in their wallet. Christian had reported something similar 2 weeks ago on testflight: https://rainbowhaus.slack.com/archives/C02C2FVC6N6/p1643863488458799 |
osdnk
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps react-native-fast-image's SDWebImage dependency to include this change: SDWebImage/SDWebImage#3280
There's still an issue where if a GIF is in a sheet and you're dragging the sheet, the speed changes while dragging, but otherwise this fixes the issue
Fixes RNBW-2590
What changed (plus any additional context for devs)
fast image looks like its not being maintained anymore so we've patched and updated the SDWebImage to better handle promotion displays
PoW (screenshots / screen recordings)
Dev checklist for QA: what to test
Final checklist