New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor BalanceCoinRow into FastBalanceCoinRow and FastCoinIcon #3313
Merged
Merged
Changes from all commits
Commits
Show all changes
75 commits
Select commit
Hold shift + click to select a range
044a9e2
Add WIP FastBalanceCoinRow
terrysahaidak 5a57e58
Ditch the useAccountSettings hook from useAccountAsset
terrysahaidak 3715a8e
WIP Editing assets
terrysahaidak 05732e7
Do not run includes when it's not needed
terrysahaidak 902f9c6
Fix unnecesarry rerenders when editing assets
terrysahaidak a58e9f5
Fix useAccountAsset
terrysahaidak 5d335af
Fast icons for rows (#3316)
osdnk 931a5e9
Simplify fallback icon
terrysahaidak 455a8ea
Fix CoinChainBadge
terrysahaidak c3dce23
Fix styles
terrysahaidak 4b7e3cd
Fix pin/hide icons
terrysahaidak dcb194b
Merge remote-tracking branch 'origin/develop' into @terrysahaidak/fas…
terrysahaidak 22cebb8
Make fast coin icon faster
terrysahaidak 04e3c38
Remove unnecessary context
terrysahaidak b8946ec
Merge remote-tracking branch 'origin/develop' into @terrysahaidak/fas…
terrysahaidak ab0ebb0
Better icon
osdnk 97af3de
Make ButtonPressAnimation on android tiny bit faster
terrysahaidak 69180b3
Use @rainbow-me import for assets
terrysahaidak 7a97f85
Don't use math when it's not needed :D
terrysahaidak fca4811
Improve typings of FastCoinBadge
terrysahaidak 0c297aa
Merge branch '@terrysahaidak/fast-balance-coin-row' of https://github…
terrysahaidak 622cc09
Fix linting issues
terrysahaidak 4f12ace
type
osdnk 4c93242
use object with pinned coins and hidden coins (#3345)
osdnk 8318e3c
Migration v16
osdnk ee76c40
fix addHiddenCoins
osdnk c2e9586
Add cache to pseudoRandomArrayItemFromString
terrysahaidak 6259fa9
assetType is optional
terrysahaidak 5a3e79b
Do not flicker the coin icon image; cache availability
terrysahaidak d9de929
Add shadow back
terrysahaidak 88f5418
Merge remote-tracking branch 'origin/develop' into @terrysahaidak/fas…
terrysahaidak 308cf99
Make linter happy
terrysahaidak bed39b3
Merge remote-tracking branch 'origin/develop' into @terrysahaidak/fas…
terrysahaidak 35c5439
Fix edit button
terrysahaidak 3be86a6
Merge remote-tracking branch 'origin/develop' into @terrysahaidak/fas…
terrysahaidak dcd7127
Do not rebuils unnecesarry wallet sections
terrysahaidak 184f7be
Update codeowners
terrysahaidak 076d180
Remove magic memo and fix update based on props
terrysahaidak a6b116c
Improve dependency debugger
terrysahaidak 80ad782
Remove unnecesarry stagger of small balances
terrysahaidak e4ad7ea
Merge remote-tracking branch 'origin/develop' into @terrysahaidak/fas…
terrysahaidak ba0400a
Merge branch '@terrysahaidak/fix-unnecessary-wallet-sections-creation…
terrysahaidak 4ae584d
Fix merge conflicts
terrysahaidak ba799ea
Update src/components/asset-list/RecyclerAssetList2/FastComponents/Fa…
terrysahaidak a17f6ff
Update src/components/asset-list/RecyclerAssetList2/FastComponents/Fa…
terrysahaidak e466d89
Update src/components/asset-list/RecyclerAssetList2/FastComponents/Fa…
terrysahaidak 93fc8f6
Remove unused import
terrysahaidak 8b92467
Merge branch 'develop' into @terrysahaidak/fast-balance-coin-row
osdnk 2c60b35
Random fixes
terrysahaidak 9c1fa51
Merge branch '@terrysahaidak/fast-balance-coin-row' of https://github…
terrysahaidak 380ce43
Merge remote-tracking branch 'origin/develop' into @terrysahaidak/fas…
terrysahaidak bf7e450
Update stuff according to profiles stuff
terrysahaidak 9417548
Address reviews
terrysahaidak 2b00268
revert fast-image patch
terrysahaidak b8ee401
Fix typings
terrysahaidak d40e1bd
Use Image for static coin badge icons
terrysahaidak 322fee7
More fixes
terrysahaidak 4763506
More review feedback
terrysahaidak d6f5165
fix useCollectible
terrysahaidak 0f968da
remove type annotation in useCollectible
terrysahaidak 996443a
Merge remote-tracking branch 'origin/develop' into @terrysahaidak/fas…
terrysahaidak 1798c57
Merge remote-tracking branch 'origin/develop' into @terrysahaidak/fas…
terrysahaidak d055486
Fix broken selec unique token sheet
terrysahaidak bea48fd
Fix selecting NFTs
terrysahaidak d535fc4
Fix passing type to raw recycling view
terrysahaidak 1e7ba12
Improve layout based on previous version
terrysahaidak daddb29
Improve edit mode layout
terrysahaidak 346e1df
Fix fast-image patch
terrysahaidak dc8b19c
Merge remote-tracking branch 'origin/develop' into @terrysahaidak/fas…
terrysahaidak 281d715
Fix the badge
terrysahaidak 33d2af8
Fix edit mode
terrysahaidak b3c64c8
Improve more
terrysahaidak a32f3a9
Refactor FastCoinIcon
terrysahaidak 2511ce4
Merge remote-tracking branch 'origin/develop' into @terrysahaidak/fas…
terrysahaidak 0613972
Fix edit options actions
terrysahaidak File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you use a different name than
cx
? I have a hard time knowing what is it about. I think I already changed something about thesz
in animated styles in another componentThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cx is actually a really popular name for such things if you've ever used css-modules in react.
but yeah I'll consider something else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think cx is ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it is some kind of react convention, then great I didn't know that