New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade reanimated #5200
Merged
Merged
Upgrade reanimated #5200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christianbaroni
requested review from
benisgold,
skylarbarrera and
jinchung
as code owners
November 22, 2023 00:54
This reverts commit fff25a6.
I suspect the request for 120fps is being rejected, so instead this requests a range of 80-120fps, with a preferred frame rate of 80fps — any higher than 80fps resulted in a lower frame rate, presumably because the request was rejected This should improve frame rates for all animations throughout the app
brunobar79
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
benisgold
approved these changes
Mar 5, 2024
skylarbarrera
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed (plus any additional context for devs)
This PR also patches reanimated with this change to
REANodesManager.mm
(this only affects iOS):Docs: https://developer.apple.com/documentation/quartzcore/cadisplaylink/3875343-preferredframeraterange
I suspect the request for 120fps is being rejected, so instead this requests a range of 80-120fps, with a preferred frame rate of 80fps — any higher than 80fps resulted in a lower frame rate (40-60fps), presumably because the request was rejected.
The consequence of this change is that animations run at ~80fps on Pro Motion devices instead of fluctuating between 40-60fps.
What to test