Points fixes #5219
Merged
Points fixes #5219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…@benisgold/points-tab-data
…@benisgold/points-tab-data
…-me/rainbow into @benisgold/points-tab-data
…ow-me/rainbow into @benisgold/points-signing
…w-me/rainbow into @christian/points-claim-flow
…-me/rainbow into @benisgold/points-fixes
skylarbarrera
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
looks so dope
few smol tings I noticed
date is too long/creating a new line: https://cloud.skylarbarrera.com/IMG_DEF39AB786D8-1.jpeg
super nit - this copy seems kinda weird if the user ONLY gets bonus points: https://cloud.skylarbarrera.com/IMG_DEF39AB786D8-1.jpeg
| @@ -104,11 +103,9 @@ export const ConsoleSheet = () => { | |||
| }, [accountAddress]); | |||
|
|
|||
| useEffect(() => { | |||
There was a problem hiding this comment.
do we need this at all then? initial values for all of these are false
| @@ -337,11 +334,9 @@ const ClaimRetroactivePointsFlow = ({ | |||
| formatAddress(accountAddress, 4, 5)) as string; | |||
|
|
|||
| useEffect(() => { | |||
| if (IS_DEV) { | |||
There was a problem hiding this comment.
same with this, maybe need animationKey to trigger initial animation but I dont think so
| @@ -720,10 +715,8 @@ export const TypingAnimation = ({ | |||
| }, []); | |||
|
|
|||
| useEffect(() => { | |||
| if (IS_DEV) { | |||
| borderColor: outline ? borderColor : undefined, | ||
| height: small ? 44 : 48, | ||
| shadowColor: outline ? 'transparent' : color || fallbackColor, | ||
| shadowOpacity: isDarkMode ? 0.2 : 0.4, |
There was a problem hiding this comment.
you may want to define some width here so we truncate xtra long strings for i18n poips, 2 line may be fine tho
There was a problem hiding this comment.
it currently will wrap to 2 lines
…@benisgold/points-fixes
…-me/rainbow into @benisgold/points-fixes
skylarbarrera
added a commit
that referenced
this pull request
Dec 11, 2023
* points tab ui * i18n * fix * fix android * android fix * Points: hook up points tab ui to metadata api (#5176) * points hook * some error state + pull to refresh * fix copy haptic + pull to refresh * fix * Points: introductory flow (#5201) * refactor * claim logic * mutation * claim content * referral screen * referral ui * temp * fix android input and tabs * fix animation + back button android * layout fixes * final fixes + i18n * Points: signing up (#5210) * Add SF Mono, SF Pro Rounded Black * Add AnimatePresence * Update green/red colors * Add ConsoleSheet * Hook up iOS fonts * Hook up to PointsScreen * Style fixes * hook up some logic to claim signing * no retroactive points ui * fix points content layout * fix * i18n * fix error logging --------- Co-authored-by: Christian Baroni <7061887+christianbaroni@users.noreply.github.com> * remove obsolete useFocusEffect * ImgixImage * simulationClient -> metadataPOSTClient --------- Co-authored-by: Christian Baroni <7061887+christianbaroni@users.noreply.github.com> --------- Co-authored-by: Christian Baroni <7061887+christianbaroni@users.noreply.github.com> * merge fix * Points fixes (#5219) * points hook * some error state + pull to refresh * fix copy haptic + pull to refresh * refactor * claim logic * fix * mutation * Add SF Mono, SF Pro Rounded Black * Add AnimatePresence * Update green/red colors * Add ConsoleSheet * Hook up iOS fonts * Hook up to PointsScreen * Style fixes * claim content * referral screen * referral ui * temp * fix android input and tabs * fix animation + back button android * layout fixes * final fixes + i18n * hook up some logic to claim signing * no retroactive points ui * fix points content layout * fix * animiation fix * referral code ui * fix invalid referral error * remove leaderboard row nav to profile * remove obsolete card + add rank card * black font weight for total points * refetch if past next distribution date * change rank icon to support higher ranks * leaderboard up to rank 100 * fix black font android * tweak sf mono font * dont render ens nft avatars in leaderboard * ActionButton * points icon animation * fix points gradient * format total # points users * restrict read only wallets * copy * referral code query update * fixing referral validation * fix merge error * fix referral code input * change metadata api fetch method from post to get * routes * i18n * console sheet nav --------- Co-authored-by: Christian Baroni <7061887+christianbaroni@users.noreply.github.com> * add contentful points tweet intent schema and queries (#5228) * i18n * real referral url * rm TAB_BAR_HEIGHT * Add referral share step (#5229) * add contentful points tweet intent schema and queries * progress on points share screen * finish flow * clean up code and break it into smaller files * refactor progress * final changes * finished up * lint * revert graphql endpoint test * share bonus points --------- Co-authored-by: Ben Goldberg <bengoldberg@rainbow.me> * fix referral skeleton ui * fix android NeonButton * cleanup * types * add 3 dots back to calculating points * fix share link * fix android shadow clipping * fix continue button not showing * [APP-972]: Fix back button being under the bottom tab bar (#5231) * fix continue button not showing * fix back button being under the bottom tabbar * 1000 -> 100 bonus pts * add a hardcoded version of tweet intent to build copy (#5235) * fix placeholder on android (#5234) * add proper twitter intents * change intent slightly * fix: rainbow text spacing and font issues * fix fonts * Bug bash fixes (#5237) * additional onboard error handling * fix skip * copy * bump referral keyboard delay * fix double referral link when sharing * fix next drop card date conversion * tweak refetch interval slightly * twitter intent tweak * fix console animation + hide mm row if 0 * console button animation delay * tweak twitter intent * bonus points -> welcome bonus || true believer * block hardware wallet * leaderboard row onpress + refactor * next drop card tweak * deeplink * referral bug fix * fix android referral code text color * attempt to fix ledger sign on console sheet * analytics events * fix android points mask * add ledger (#5233) * add ledger * logs * logs * logs * analytics events * tweaks * logs * moar logs --------- Co-authored-by: Ben Goldberg <bengoldberg@rainbow.me> * remove url encoded (#5240) * added analytics events * next drop rounding fix * rm console logs --------- Co-authored-by: Christian Baroni <7061887+christianbaroni@users.noreply.github.com> Co-authored-by: Matthew Wall <matthew.wallt@gmail.com> Co-authored-by: Derek <dereknelsony0@gmail.com> Co-authored-by: Skylar Barrera <skylar.barrera@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed (plus any additional context for devs)
What to test
TF 1.9.11 (10)
just try different variations of the points onboarding flow and try to break it
undefinedvalues in the points breakdown at the end of the onboarding flowPointsContentscreen after completing the onboarding flow. it should never bring you back to the beginning of the onboarding flow (ClaimContentscreen)