Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swaps: revert entry point #5247

Merged
merged 1 commit into from
Dec 14, 2023
Merged

swaps: revert entry point #5247

merged 1 commit into from
Dec 14, 2023

Conversation

skylarbarrera
Copy link
Contributor

@skylarbarrera skylarbarrera commented Dec 12, 2023

Fixes APP-956 APP-954

What changed (plus any additional context for devs)

changes the swap entry point to be the main swap screen instead of the currency select modal

3 cases -> swap button, swap existing asset, swap to a new asset(discover)

added subtitle only to the receive current select list as well

Screen recordings / screenshots

https://cloud.skylarbarrera.com/Screen-Recording-2023-12-12-15-00-55.mp4

What to test

cases

Copy link

linear bot commented Dec 12, 2023

Copy link

linear bot commented Dec 12, 2023

@jinchung jinchung added the release for release blockers and release candidate branches label Dec 14, 2023
Copy link
Contributor

@walmat walmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Went through entire flow on Android and it worked well.

Probably not isolated to anything changed from this PR, but noticed that the Max button takes ages to work sometimes.

Screen.Recording.2023-12-14.at.10.50.57.AM.mov

@jinchung jinchung merged commit a7c057e into develop Dec 14, 2023
5 of 6 checks passed
@jinchung jinchung deleted the @skylar/swap-entry-point-tweak branch December 14, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release for release blockers and release candidate branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants