Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Points: some number formatting #5251

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Conversation

benisgold
Copy link
Member

Fixes APP-1006, APP-999

What changed (plus any additional context for devs)

  • add commas to rank card rank in points tab
  • add commas to # of pts distributed in tweet intent

Screen recordings / screenshots

Simulator Screenshot - iPhone 14 Pro - 2023-12-12 at 17 04 03
Simulator Screenshot - iPhone 14 Pro - 2023-12-12 at 16 56 18

What to test

Copy link

linear bot commented Dec 13, 2023

@jinchung jinchung merged commit 8b54d8e into develop Dec 14, 2023
5 of 6 checks passed
@jinchung jinchung deleted the @benisgold/points-formatting branch December 14, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants