Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Points: fix tweet intent #5280

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Points: fix tweet intent #5280

merged 2 commits into from
Dec 15, 2023

Conversation

benisgold
Copy link
Member

@benisgold benisgold commented Dec 15, 2023 •
edited

Fixes APP-####

What changed (plus any additional context for devs)

  • due to potential encoding differences, newlines are not showing up on android. quick fix is to replace newlines with spaces on android

follow-up: https://linear.app/rainbow/issue/APP-1029/investigate-encodeuricomponent-cross-platform-differences

Screen recordings / screenshots

Screenshot 2023-12-15 at 12 40 51 PM ![Simulator Screenshot - iPhone SE (3rd generation) - 2023-12-15 at 12 41 14](https://github.com/rainbow-me/rainbow/assets/15272675/e0109047-b71f-4b10-bdcb-b23f53b9375b)

What to test

@benisgold benisgold changed the title Points: encode tweet intent Points: fix tweet intent Dec 15, 2023
@benisgold benisgold added release for release blockers and release candidate branches rainbow points labels Dec 15, 2023
jinchung
jinchung approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@jinchung jinchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@jinchung jinchung merged commit 060e4fd into develop Dec 15, 2023
5 of 6 checks passed
@jinchung jinchung deleted the @benisgold/points-tweet-intent branch December 15, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinchung jinchung jinchung approved these changes

@walmat walmat Awaiting requested review from walmat

@dereknelson dereknelson Awaiting requested review from dereknelson

@skylarbarrera skylarbarrera Awaiting requested review from skylarbarrera

Assignees
No one assigned
Labels
rainbow points release for release blockers and release candidate branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@benisgold @jinchung