search: l2 clean up #5333
Merged
search: l2 clean up #5333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skylarbarrera
commented
Jan 22, 2024
| ? asset?.networks | ||
| ? { | ||
| ...ethereumUtils.formatGenericAsset(genericAsset, nativeCurrency), | ||
| type: asset.type, |
There was a problem hiding this comment.
networks only exists if coming from search, this overrides types to allow for l2 only assets for this screen
skylarbarrera
commented
Jan 22, 2024
| @@ -415,7 +421,7 @@ export default function ChartExpandedState({ asset }) { | |||
| <BuyActionButton color={color} /> | |||
| </SheetActionButtonRow> | |||
| ) : null} | |||
| {isL2 && ( | |||
| {!networks && isL2 && ( | |||
There was a problem hiding this comment.
just making sure we done show 2 network disclaimers if coming from search
skylarbarrera
commented
Jan 22, 2024
| @@ -545,7 +545,7 @@ | |||
| "read_more_button": "Read more", | |||
| "available_networks": "Available on %{availableNetworks} networks", | |||
| "available_network": "Available on the %{availableNetwork} network", | |||
| "available_networkv2": "Also available on %{availableNetwork}", | |||
| "available_networkv2": "Only available on %{availableNetwork}", | |||
There was a problem hiding this comment.
copy change to support if the asset is only on 1 network, which previously was not possible
benisgold
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1090
What changed (plus any additional context for devs)
this exposed a few regressions that came from us allowing search of L2 only assets, before search ran under the assumption that all results were on mainnet which is no longer the case. working on a few smol tweaks rn
there's some more work that can be done but its contingent on us moving off out zerion websockets first
Screen recordings / screenshots
https://cloud.skylarbarrera.com/Screen-Recording-2024-01-22-12-57-56.mp4
What to test