Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Points: require wallet balance UI #5341

Merged
merged 2 commits into from Jan 26, 2024
Merged

Conversation

benisgold
Copy link
Member

@benisgold benisgold commented Jan 24, 2024

Fixes APP-1032

What changed (plus any additional context for devs)

  • added ConsoleSheet step for handling backend error type that rejects user from onboarding due to not having a wallet balance
  • tweaked some error handling, we were unnecessarily logging errors

Screen recordings / screenshots

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-01-23.at.17.30.14.mp4
Screen_Recording_20240123-194628_Rainbow.mp4

What to test

If you have a wallet w/ a balance that has not onboarded to points yet, would be good to test that

Copy link

linear bot commented Jan 24, 2024

color={textColors.gray}
delayStart={500}
weight="normal"
textContent={' - Ethereum'}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we map these to RainbowNetworks? will allow us to auto add new networks

Copy link
Contributor

@skylarbarrera skylarbarrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one smol nit

@benisgold benisgold merged commit ed1df89 into develop Jan 26, 2024
6 checks passed
@benisgold benisgold deleted the @benisgold/points-require-balance branch January 26, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants