Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace genericAssets #5357

Merged
merged 23 commits into from Feb 2, 2024
Merged

chore: replace genericAssets #5357

merged 23 commits into from Feb 2, 2024

Conversation

skylarbarrera
Copy link
Contributor

@skylarbarrera skylarbarrera commented Jan 26, 2024

Fixes APP-1102 APP-876

What changed (plus any additional context for devs)

Screen recordings / screenshots

What to test

Copy link

linear bot commented Jan 26, 2024

Copy link

linear bot commented Jan 29, 2024

src/resources/assets/externalAssetsQuery.ts Outdated Show resolved Hide resolved
src/resources/assets/externalAssetsQuery.ts Outdated Show resolved Hide resolved
src/resources/assets/externalAssetsQuery.ts Show resolved Hide resolved
nativeAsset = store.getState().data?.genericAssets?.[mainnetAddress];
const externalAsset = await queryClient.fetchQuery(
ExternalTokenQueryKey({ address, network, currency: nativeCurrency }),
async () =>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add this fetcher (generically) to externalAssetsQuery.ts?

src/utils/ethereumUtils.ts Outdated Show resolved Hide resolved
@skylarbarrera skylarbarrera merged commit b784b8f into develop Feb 2, 2024
6 checks passed
@skylarbarrera skylarbarrera deleted the @skylar/external-assets branch February 2, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants