transactions: refactor #5369
Merged
transactions: refactor #5369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walmat
reviewed
Jan 31, 2024
|
Okay had to bump prettier version in this branch to play nicely with zustand. Forced a write which is why file amount is large. |
This reverts commit 0ead5a0.
skylarbarrera
commented
Feb 10, 2024
skylarbarrera
commented
Feb 10, 2024
skylarbarrera
requested review from
walmat,
jinchung,
dereknelson and
benisgold
benisgold
reviewed
Feb 12, 2024
| // @ts-expect-error ts-migrate(7031) FIXME: Binding element 'title' implicitly has an 'any' ty... Remove this comment to see the full error message | ||
| ({ title }) => title === 'Pending' | ||
| ); | ||
| const pendingSectionIndex = sectionedTransactions.findIndex(({ title }) => title === 'Pending'); |
There was a problem hiding this comment.
@skylarbarrera not sure what the correct logic is here but seems like it should match https://github.com/rainbow-me/rainbow/pull/5369/files#diff-62d641fbc0fd2cd84a2d7e0b31ac36fcaa66ad4c5601819ca4a18546ff1015d2R98
skylarbarrera
added
the
release
ibrahimtaveras00
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-800
What changed (plus any additional context for devs)
Screen recordings / screenshots
What to test