added USD asset price next to currency rows (send) in tx sim #5374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
last q, are the $ amounts formatted properly? e.g. |
|
@christianbaroni it is now, good catch |
walmat
approved these changes
Feb 1, 2024
Comment on lines
+2114
to
+2117
| const showUSD = (eventType === 'send' || eventType === 'receive') && price; | ||
| const formattedPrice = `$${price?.toLocaleString?.('en-US', { | ||
| maximumFractionDigits: 2, | ||
| })}`; |
There was a problem hiding this comment.
Not a blocker on this PR at all, but wonder if it's worth opening up a backlog to explore instances where we display currency and match it to the user's desired currency that they chose in settings.
Seems like in a lot of places we assume USD
There was a problem hiding this comment.
yeah i think if we're not doing USD we'd keep currency pref on backend and strip all locale conversions on client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1122
What changed (plus any additional context for devs)
now we have a USD value for what you're swapping!
Screen recordings / screenshots
What to test
that send amounts show up