chore: migrate nonce state #5395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skylarbarrera
requested review from
derHowie,
benisgold and
jinchung
as code owners
skylarbarrera
commented
Feb 9, 2024
| @@ -50,7 +46,7 @@ export default function useLoadGlobalLateData() { | |||
| // tx method names | |||
| const p7 = dispatch(transactionSignaturesLoadState()); | |||
|
|
|||
| promises.push(p1, p2, p3, p4, p5, p6, p7); | |||
| promises.push(p2, p3, p4, p5, p6, p7); | |||
There was a problem hiding this comment.
can rename these but meh, we should slowly try to remove all of these
There was a problem hiding this comment.
nitpick but can you rename these to p1, p2, p3, p4, p5, p6
skylarbarrera
commented
Feb 9, 2024
| if (addressFrom && nonce) { | ||
| // @ts-ignore-next-line | ||
| dispatch(incrementNonce(addressFrom!, nonce, network)); | ||
| if (!isNil(addressFrom) && nonce) { |
skylarbarrera
commented
Feb 9, 2024
| @@ -650,7 +648,7 @@ export const SignTransactionSheet = () => { | |||
| const sendInsteadOfSign = transactionDetails.payload.method === SEND_TRANSACTION; | |||
| const txPayload = req; | |||
| let { gas, gasLimit: gasLimitFromPayload } = txPayload; | |||
|
|
|||
| if (!currentNetwork) return; | |||
skylarbarrera
commented
Feb 9, 2024
walmat
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed (plus any additional context for devs)
migrating nonce management to zustand in prep for txs migration
implementation matches bx
Screen recordings / screenshots
What to test