Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix saving nft images #5447

Merged
merged 1 commit into from Mar 1, 2024
Merged

fix saving nft images #5447

merged 1 commit into from Mar 1, 2024

Conversation

benisgold
Copy link
Member

Fixes APP-101, APP-428

What changed (plus any additional context for devs)

  • update import from camera roll package
  • switch unique asset image url that was being saved. before, some ipfs uris were sneaking thru

Screen recordings / screenshots

What to test

need to test on android still

@linear Linear
Copy link

linear bot commented Feb 29, 2024

APP-101 Error saving Optimism and Arbitrum NFTs to photos

skylarbarrera
skylarbarrera approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@skylarbarrera skylarbarrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@benisgold benisgold merged commit 7d2d61b into develop Mar 1, 2024
6 checks passed
@benisgold benisgold deleted the @benisgold/save-image branch March 1, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skylarbarrera skylarbarrera skylarbarrera approved these changes

@walmat walmat Awaiting requested review from walmat

@dereknelson dereknelson Awaiting requested review from dereknelson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@benisgold @skylarbarrera