Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Android clipboard alerts #5486

Merged
merged 4 commits into from
Mar 12, 2024
Merged

Fix Android clipboard alerts #5486

merged 4 commits into from
Mar 12, 2024

Conversation

christianbaroni
Copy link
Member

What changed (plus any additional context for devs)

  • Stops the constant clipboard alerts on Android (only present on Android 12 and higher)
  • Pasting now works the same way it does on iOS, with one caveat: unlike on iOS, on Android 12+, Clipboard.hasString() triggers an alert, so we skip that and instead read from the clipboard only when it's initiated by the user
  • Quickly tested on both platforms and found no issues, but did not test everywhere we have paste functionality

@socket-security Socket Security

This comment was marked as outdated.

Sign in to view
@socket-security Socket Security

This comment was marked as outdated.

Sign in to view
walmat
walmat approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@walmat walmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

legend. TYSM for this

@christianbaroni
Copy link
Member Author

Discussed with Bruno, seems like Socket is having issues and the reports above are unrelated to this PR

skylarbarrera
skylarbarrera approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@skylarbarrera skylarbarrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

@christianbaroni christianbaroni merged commit 6853b79 into develop Mar 12, 2024
4 of 6 checks passed
@christianbaroni christianbaroni deleted the @christian/fix-android-clipboard-alerts branch March 12, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walmat walmat walmat approved these changes

@benisgold benisgold benisgold approved these changes

@skylarbarrera skylarbarrera skylarbarrera approved these changes

@ibrahimtaveras00 ibrahimtaveras00 Awaiting requested review from ibrahimtaveras00

@jinchung jinchung Awaiting requested review from jinchung

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@christianbaroni @walmat @benisgold @skylarbarrera