Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

complete checks > complete check #5495

Merged
merged 2 commits into from
Apr 17, 2024
Merged

complete checks > complete check #5495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f14b30d
init
BrodyHughes Mar 12, 2024
402d75c
Merge branch 'develop' of github.com:rainbow-me/rainbow into brody/ch…
BrodyHughes Apr 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/send/SendButton.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export default function SendButton({
isAuthorizing={isAuthorizing}
label={
disabled && requiresChecks
? `􀄨 ${lang.t('wallet.transaction.complete_checks')}`
? `􀄨 ${lang.t('wallet.transaction.complete_check')}`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be plural with ENS p sure, we may need to count the checks

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh yeah i'll look at it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skylarbarrera
All the ENS checks are optional so it actually doesn't apply here.
Screenshot 2024-04-17 at 10 29 30 AM

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also i forgot about this PR lol

: insufficientEth
? lang.t('button.confirm_exchange.insufficient_funds')
: lang.t('button.hold_to_send')
Expand Down
2 changes: 1 addition & 1 deletion src/languages/en_US.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2577,7 +2577,7 @@
"insufficient_funds": "Oh no! The gas price changed and you no longer have enough funds for this transaction. Please try again with a lower amount.",
"generic": "Oh no! There was a problem submitting the transaction. Please try again."
},
"complete_checks": "Complete checks",
"complete_check": "Complete check",
"ens_configuration_options": "ENS configuration options",
"confirm": "Confirm transaction",
"max": "Max",
Expand Down