txs: add pending tx indicator #5529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benisgold
requested changes
Mar 18, 2024
There was a problem hiding this comment.
some things i noticed:
- text is off center
- missing background color inside spinner
- spinner stops & restarts animation when switching tabs
- swaps spinner which is being used here doesnt match spec, looks kinda weird imo but fine if we keep it
- idk if this exists in design spec, but if you nav to the tx tab, the tab highlight color blends in w/ the spinner/text color
i made some of these changes (first two bullets) that you can merge in if you want, see this commit 070fa9f
benisgold
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1225
What changed (plus any additional context for devs)
Added pending tx indicat0r
Screen recordings / screenshots
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-03-18.at.14.36.01.mp4
What to test