-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleaning up e2e #5540
Merged
Merged
cleaning up e2e #5540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New and removed dependencies detected. Learn more about Socket for GitHub 鈫楋笌
馃毊 Removed packages: npm/@types/jest@29.5.4, npm/detox@20.13.0 |
BrodyHughes
requested review from
benisgold,
skylarbarrera and
jinchung
as code owners
March 21, 2024 17:15
skylarbarrera
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
max lvl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed (plus any additional context for devs)
Lots of little changes:
'jest/expect-expect': 'off',
and'jest/no-disabled-tests': 'off',
for now to our linting rules. the first one makes it to where jest doesn't require anexpect()
statement in every test, the second one allows us to skip tests without jest complainingactions/checkout@v4
Helper.helperHere
syntax. I think it just looks better 馃槄test.disabled.js
and moved them to adisabled
folder for organization sakethis.launchAppTimeout = 120_000
and increased thethis.initTimeout
in the environment.js fileimportWalletFlow()
helper since this is super reusedisTesting===true
What to test