Fix random quote edge cases #5644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
walmat
commented
Apr 19, 2024
walmat
commented
- Fixed some edge cases when user chooses to swap assets
- Fixed some missing logic in the useSwapWarning hook that prevented warnings from being reset
walmat
commented
Apr 19, 2024
Comment on lines
+397
to
+403
| inputValues.modify(prev => { | ||
| return { | ||
| ...prev, | ||
| outputAmount: 0, | ||
| outputNativeValue: 0, | ||
| }; | ||
| }); |
There was a problem hiding this comment.
when we receive a quote error, we want to make sure we reset the output values so that they aren't previous quote values
skylarbarrera
approved these changes
Apr 19, 2024
walmat
commented
Apr 19, 2024
BrodyHughes
added a commit
that referenced
this pull request
Apr 22, 2024
…eplink-add * 'develop' of github.com:rainbow-me/rainbow: Cover a few more edge cases with showing the swap warnings (#5648) refetch quote if a user selects a new assset to sell with a buy asset already selected (#5643) Fix random quote edge cases (#5644) use dapp metadata where possible (#5629) Output chain selection context menu (#5630) chore: use native currency balances (#5631) browser: android fixes (#5642) Review Sheet (#5632)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.