prep for swap quote fetching #5711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walmat
requested review from
nickbytes,
benisgold,
skylarbarrera and
jinchung
as code owners
benisgold
reviewed
May 13, 2024
| ? 'ethereum' | ||
| : chainNameFromChainIdWorklet(SwapInputController.outputChainId.value) | ||
| : chainNameFromChainIdWorklet(internalSelectedOutputAsset.value?.chainId ?? ChainId.mainnet) |
There was a problem hiding this comment.
if chainId falls back to mainnet, should we set chainName to 'ethereum' as we do on line 41 instead of calling chainNameFromChainIdWorklet?
There was a problem hiding this comment.
yes tbh review panel is going to need hooked up in a follow-up PR. nothing done to this except gutting the old asset stuff out.
benisgold
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1456
What changed (plus any additional context for devs)
Screen recordings / screenshots
What to test