browser: android fixes v2 #5712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walmat
reviewed
May 10, 2024
| @@ -529,7 +538,6 @@ const styles = StyleSheet.create({ | |||
| overflow: 'hidden', | |||
| top: 0, | |||
| width: DEVICE_WIDTH, | |||
| zIndex: 50000, | |||
walmat
reviewed
May 10, 2024
| }, [canGoBack, canGoForward, isFavorite, tabUrl]); | ||
|
|
||
| const onPressMenuItem = useCallback( | ||
| async ({ nativeEvent: { actionKey } }: { nativeEvent: { actionKey: 'share' | 'favorite' | 'back' | 'forward' } }) => { |
There was a problem hiding this comment.
would prefer these all to be typed properly going forward.
import { OnPressMenuItemEventObject } from 'react-native-ios-context-menu';
walmat
approved these changes
May 10, 2024
| options: menuConfig.menuItems.map(item => item?.actionTitle), | ||
| }, | ||
| (buttonIndex: number) => { | ||
| onPressMenuItem({ nativeEvent: { actionKey: menuConfig.menuItems[buttonIndex]?.actionKey as any } }); |
There was a problem hiding this comment.
same here, use the proper type:
import { OnPressMenuItemEventObject } from 'react-native-ios-context-menu';
walmat
reviewed
May 10, 2024
Comment on lines
+137
to
+139
| } else { | ||
| const url = activeTabInfo.value.url; | ||
| if (url) handleShareUrl(url); |
There was a problem hiding this comment.
i think this clause will be hit on android if they cancel the action sheet.
There was a problem hiding this comment.
only change that's needed. Others are nits @skylarbarrera
There was a problem hiding this comment.
im gonna merge this in and handle in my next PR, nice catch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1342
Fixes APP-1436
Fixes APP-1340
also added i18n where missing, fixed some small android style issues
What changed (plus any additional context for devs)
Screen recordings / screenshots
What to test