Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

browser: fix direct search #5719

Merged
merged 1 commit into from
May 14, 2024
Merged

browser: fix direct search #5719

merged 1 commit into from
May 14, 2024

Conversation

skylarbarrera
Copy link
Contributor

@skylarbarrera skylarbarrera commented May 13, 2024 •
edited by nickbytes
Loading

Fixes APP-1467

What changed (plus any additional context for devs)

Uploading Simulator Screen Recording - iPhone 15 Pro - 2024-05-13 at 18.13.47.mp4…

Screen recordings / screenshots

What to test

@linear Linear
Copy link

linear bot commented May 13, 2024

APP-1467 if you type a valid URL that returns a dapp result, you can only go to the URL in the suggested result. You should be able to go to the exact URL (vs the suggested).

@christianbaroni christianbaroni self-requested a review May 14, 2024 17:40
@skylarbarrera skylarbarrera merged commit 0a1511e into develop May 14, 2024
6 checks passed
@skylarbarrera skylarbarrera deleted the @skylar/search branch May 14, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianbaroni christianbaroni christianbaroni approved these changes

@brunobar79 brunobar79 Awaiting requested review from brunobar79 brunobar79 is a code owner

@benisgold benisgold Awaiting requested review from benisgold benisgold is a code owner

Assignees
No one assigned
Labels
dapp browser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@skylarbarrera @christianbaroni @jinchung