Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser: homepage empty state, search logic fixes #5737

Merged
merged 10 commits into from
May 16, 2024

Conversation

christianbaroni
Copy link
Member

@christianbaroni christianbaroni commented May 16, 2024

What changed (plus any additional context for devs)

  • Adds a basic homepage empty state
  • Fixes dynamic tab bar positions and styles (e.g. when browser tab is enabled/disabled — was previously buggy)
  • Improves light mode browser button shadows
  • Improves search logic
  • Fixes search result styles

Screen recordings / screenshots

What to test

@christianbaroni christianbaroni changed the title Browser: homepage empty state Browser: homepage empty state, search logic fixes May 16, 2024
Copy link
Member

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@brunobar79 brunobar79 merged commit a48f46a into develop May 16, 2024
6 checks passed
@brunobar79 brunobar79 deleted the @christian/browser-homepage-empty-state branch May 16, 2024 14:50
BrodyHughes added a commit that referenced this pull request May 21, 2024
…x-qr-code-sheet

* 'develop' of github.com:rainbow-me/rainbow: (56 commits)
  review panel fixes (#5747)
  Account for NaN values on sliderPosition (#5741)
  add myself to CO for PR approvals (#5743)
  bump version to v1.9.24 (#5742)
  Asset Prices (#5724)
  rm references to old redux swaps const (#5740)
  Swap Warning / Price Impact component (#5722)
  add animated coin icons and text fallbacks (#5733)
  adds ability to select a different output chain id (#5727)
  fix (#5738)
  fix positions calling without address (#5729)
  disable button (#5725)
  Browser: homepage empty state, search logic fixes (#5737)
  Add privacy manifest (#5736)
  swaps and bridge checks on control panel (#5735)
  Browser: fix control panel crash (#5734)
  Browser: control panel fixes (#5730)
  f skylar (#5732)
  fix account switching (#5726)
  Browser: release fixes (#5721)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants