Fix weird favorites state #5783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: src/swaps/screens/Swap/hooks/useSearchCurrencyLists.ts
Did you find this useful? React with a 👍 or 👎 |
walmat
changed the title
| fav.address === ETH_ADDRESS ? '0x0000000000000000000000000000000000000000' === address : fav.address === address | ||
| ); | ||
| // console.log(address, favorites); | ||
| return Object.values(favoritesMetadata).find(fav => fav.address === address); |
There was a problem hiding this comment.
did this to compare addresses, idk if it's useful here if so we can extract to a util
https://github.com/rainbow-me/rainbow/pull/5779/files#diff-642731cd0525a4b6dfdffbd2017e6139bd939d0fad8229022ebb288a7df2b6faR50-R55
Co-authored-by: gregs <ukfaeku@gmail.com>
Co-authored-by: gregs <ukfaeku@gmail.com>
…nbow into @matthew/APP-1515
greg-schrammel
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1515
What changed (plus any additional context for devs)
Screen recordings / screenshots
What to test