[e2e] Brody/e2e parallel #5786
Merged
[e2e] Brody/e2e parallel #5786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walmat
reviewed
May 31, 2024
Comment on lines
+25
to
+27
| "detox:ios:tests": "detox test -c ios.sim.debug --maxWorkers 2 -- --bail 1", | ||
| "detox:ios": "detox build -c ios.sim.debug | xcpretty --color && yarn detox:ios:tests", | ||
| "detox:ios:release": "detox build -c ios.sim.release && detox test -c ios.sim.release --maxWorkers 2 -- --bail 1", |
There was a problem hiding this comment.
what happens when maxWorkers > 2?
There was a problem hiding this comment.
more parallelization, but diminishing returns obvs. we have 6 tests RIGHT NOW with more to come.
1 worker = 16 mins
2 workers = 8 mins
3 workers = 5.33 mins
right now 4+ workers is awkward bc the tests become uneven so it caps out at 5.33 minutes until we hit 6 workers (num of tests).
once we add more workers and split up the tests more i think the flakiness could become a concern bc of how split resources become. i'll see how far i can push it tho! i think at least 3 is probably good.
There was a problem hiding this comment.
yeah i tried it out it seemed like more than 2 workers currently introduces some flakiness
walmat
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed (plus any additional context for devs)