Swaps: fix crashes, logic and UI fixes #5839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t change detection
christianbaroni
requested review from
brunobar79,
jinchung,
walmat and
benisgold
christianbaroni
changed the title
walmat
reviewed
Jun 12, 2024
|
|
||
| // This causes a heavy re-render in the output token list, so we delay updating the selected output chain until | ||
| // the animation is most likely complete. | ||
| chainSetTimeoutId.current = setTimeout(() => { |
Comment on lines
+171
to
+173
| const nativeValue = `${Number(inputValues.value.inputNativeValue).toLocaleString('en-US', { | ||
| currency: 'USD', | ||
| style: 'currency', |
There was a problem hiding this comment.
This will conflict with Ben's PR afaik
Comment on lines
+213
to
+215
| const nativeValue = `${Number(inputValues.value.outputNativeValue).toLocaleString('en-US', { | ||
| currency: 'USD', | ||
| style: 'currency', |
BrodyHughes
added a commit
that referenced
this pull request
Jun 13, 2024
…bow into brody/lint-on-pre-commit * 'brody/lint-on-pre-commit' of github.com:rainbow-me/rainbow: Math related fixes (#5837) Hide Flashbots outside of mainnet (#5842) fix getProviderForNetwork type (#5843) Fix isSwapping not being reset (#5840) Swaps: fix crashes, logic and UI fixes (#5839) default to fast suggestion if custom is not set (#5841) guard each entry point into swaps to prevent readonly wallets from accessing it (#5835) Swaps: token list and search improvements (#5834) Add analytics (#5805)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1538
Fixes APP-1552
Fixes APP-1582
Fixes APP-1583
Fixes APP-1591
Fixes RNBW-4755
What changed (plus any additional context for devs)
toLocaleStringchanges are temporary and will be superseded by Ben's changes)PIXEL_RATIOtodeviceUtilssetAssetwhich adds a bit of duplicate code but prevents complicatingsetAssetScreen recordings / screenshots
What to test