Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewards UI cleanup #5896

Merged
merged 12 commits into from
Jun 26, 2024
Merged

Rewards UI cleanup #5896

merged 12 commits into from
Jun 26, 2024

Conversation

christianbaroni
Copy link
Member

@christianbaroni christianbaroni commented Jun 26, 2024

What changed (plus any additional context for devs)

  • Memoizes the cards on the Rewards screen
  • Cleans up the next drop time, now shows e.g. "Today 4:20 PM" instead of "Tuesday 4:20pm" if the drop is happening at 4:20 PM on the current day
  • Trims trailing zeros from "Rainbow users have earned" amount
  • Fixes the rainbow text gradient width in the "My Points" section in the case where the device uses a non-standard system font size
  • Cleans up the pending transactions spinner in the tab bar
  • Fixes a bug causing the SmoothPager wrapper views to partly block the tap region behind the sheet in the case where the SmoothPager page heights differ
  • Removes default exports in main points components

Screen recordings / screenshots

What to test

Copy link
Member

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/screens/points/content/PointsContent.tsx Show resolved Hide resolved
@christianbaroni christianbaroni merged commit e96462c into develop Jun 26, 2024
6 checks passed
@christianbaroni christianbaroni deleted the @christian/points-ui-cleanup branch June 26, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants