Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer user asset when prefilling swap assets #5919

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Prefer user asset when prefilling swap assets #5919

merged 1 commit into from
Jul 9, 2024

Conversation

christianbaroni
Copy link
Member

What changed (plus any additional context for devs)

  • Should fix the bug causing assets in swap to sometimes not reflect your balance

Screen recordings / screenshots

What to test

brunobar79
brunobar79 approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested this with all the possible input variations:

  • native asset ETH
  • native asset L2
  • ERC20 mainnet
  • ERC20 l2

all working as expected and the "no balance / insufficient funds" issue is no longer happening

@brunobar79 brunobar79 merged commit f473b49 into develop Jul 9, 2024
6 checks passed
@brunobar79 brunobar79 deleted the @christian/possibly-fix-no-balance-bug branch July 9, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunobar79 brunobar79 brunobar79 approved these changes

@greg-schrammel greg-schrammel greg-schrammel approved these changes

@jinchung jinchung Awaiting requested review from jinchung

Assignees
No one assigned
Labels
swaps v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@christianbaroni @brunobar79 @greg-schrammel