Add "recent" swaps section to token to buy list #5956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walmat
commented
Jul 25, 2024
walmat
commented
Jul 27, 2024
Comment on lines
+28
to
+30
| export type RecentSwap = { | ||
| swappedAt: number; | ||
| } & ExtendedAnimatedAssetWithColors; |
There was a problem hiding this comment.
Do we want more metadata here?
| @@ -34,6 +36,74 @@ export interface SwapsState { | |||
| setSource: (source: Source | 'auto') => void; | |||
| degenMode: boolean; | |||
| setDegenMode: (degenMode: boolean) => void; | |||
|
|
|||
| // recent swaps | |||
| latestSwapAt: Map<ChainId, number>; | |||
There was a problem hiding this comment.
is this prop used? do we need it?
There was a problem hiding this comment.
greg-schrammel
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1635
What changed (plus any additional context for devs)
Added a new section that shows the last three user swaps per chain. These recents prioritize favorites and bridge assets if they exist in those lists.
Screen recordings / screenshots
What to test