chore: pnpm version 9, dependencies upgrades and esbuild 20.x #1958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
magiziz
commented
May 3, 2024
Comment on lines
+59
to
+67
| {...(isRemoteImage | ||
| ? // biome-ignore format: design system keys | ||
| { | ||
| "aria-hidden": true, | ||
| as: "img", | ||
| onLoad: setRemoteImageLoaded, | ||
| src, | ||
| } | ||
| : { | ||
| backgroundSize: 'cover', | ||
| })} | ||
| : { 'aria-hidden': true, as: 'img', src })} |
There was a problem hiding this comment.
esbuild 20.x has a new way of bundling dataurl's with .svg and .png, which means we can use img as of now instead of div and do backgroundImage: url(...)
magiziz
commented
May 3, 2024
site/package.json
Outdated
| "next-sitemap": "^4.2.3" | ||
| }, | ||
| "scripts": { | ||
| "dev": "next dev --port 3001", | ||
| "build": "INIT_CWD=$PWD next build", | ||
| "build": "contentlayer build && INIT_CWD=$PWD next build", |
There was a problem hiding this comment.
Needed since it has some problems on pages router. More context here
chore: configure new builds for rainbowkit and update esbuild package with pnpm 9.x chore: revert changes and add new changes for new esbuild builds chore: cleanup chore: edit package.json build file revert: removing prepare revert: remove prepare from scripts refactor: tsconfig.json chore: refactor chore: rename build.ts -
magiziz
force-pushed
the
@mago/pnpm-v9-esbuild
branch
from
0799724
to
0027aa0
Compare
DanielSinclair
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
contentlayer/next-contentlayerto0.3.4- (site -> package.json)@vanilla-extract/cssto1.15.1- (site -> package.json)@vanilla-extract/next-pluginto2.4.0- (site -> package.json)@vanilla-extract/recipesto^0.5.2- (site -> package.json)@vanilla-extract/esbuild-pluginto^2.3.5- (package.json)@vanilla-extract/vite-pluginto^4.0.9- (package.json)esbuildto^0.20.2- (package.json)/packages/*folder to include the newestesbuildfeaturesWhat to test
pnpm installandpnpm run devacross all packages / examples without having any crashesesbuildbundles them correctly as it did in0.14.39version