Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fontStack option to built-in themes #198

Merged
merged 3 commits into from
Mar 28, 2022

Conversation

markdalgleish
Copy link
Contributor

@markdalgleish markdalgleish commented Mar 28, 2022

For now this is just adding the quick win of letting you opt out of SF Pro Rounded since it has similar metrics to the system font stack. Adding to this list in the future may require more updates to the low-level theme API.

@markdalgleish markdalgleish requested a review from a team as a code owner March 28, 2022 00:29
@linear
Copy link

linear bot commented Mar 28, 2022

RNBW-2790 Expose font variables to built-in theme APIs

e.g. lightTheme({ accentColor: 'purple', font: 'Comic Sans MS' })

Note, this is blocked until RNBW-2862 is done.

This might need some discussion since different fonts have different metrics, meaning that you're also likely to want to adjust font sizes (and possibly line heights). Do we only support a set of pre-defined fonts (similar to accentColor , e.g. 'rounded' | 'system' | 'monospace') so we can ensure everything looks correct? Or if this is too constrained/unrealistic, is it possible that this isn't something we can easily support via the built-in themes and needs to be done with the low-level custom theme API where you have full control over text sizing?

@vercel
Copy link

vercel bot commented Mar 28, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

rainbowkit-site – ./

🔍 Inspect: https://vercel.com/rainbowdotme/rainbowkit-site/4uQRCeYtrSuLXVL8sQLvhBfnXdrR
✅ Preview: https://rainbowkit-site-git-markdalgleish-rnbw-2790-2fe537-rainbowdotme.vercel.app

rainbowkit-example – ./

🔍 Inspect: https://vercel.com/rainbowdotme/rainbowkit-example/DkF8nNihvH3aXjFkV1tkKkEArzab
✅ Preview: https://rainbowkit-example-git-markdalgleish-rnbw-2-2bc71f-rainbowdotme.vercel.app

@markdalgleish markdalgleish merged commit 96e78b3 into main Mar 28, 2022
@markdalgleish markdalgleish deleted the @markdalgleish/RNBW-2790-font-stack branch March 28, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants