fix: use ethers peer dependency for providers #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
markdalgleish
commented
May 5, 2022
| "react": ">=17", | ||
| "react-dom": ">=17", | ||
| "wagmi": "^0.3.2" | ||
| }, | ||
| "devDependencies": { | ||
| "@ethersproject/abstract-provider": "^5.5.1", | ||
| "@ethersproject/providers": "^5.5.1", |
There was a problem hiding this comment.
We still need this as a dev dependency for internal type checking purposes, but not for consumers.
markdalgleish
commented
May 5, 2022
| "@types/qrcode": "^1.4.2", | ||
| "@vanilla-extract/private": "^1.0.2", | ||
| "autoprefixer": "^10.4.0", | ||
| "ethers": "^5.0.0", |
There was a problem hiding this comment.
This is the same version range used through the rest of the codebase. It resolves to a much newer version in the lock file.
markdalgleish
commented
May 5, 2022
| @@ -18,7 +17,7 @@ export function TransactionStoreProvider({ | |||
| }: { | |||
| children: React.ReactNode; | |||
| }) { | |||
| const provider = useProvider<BaseProvider>(); | |||
There was a problem hiding this comment.
This didn't appear to be needed anymore. @nickbytes let me know if I'm missing something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have a direct dependency on
@ethersproject/providers, but this means that provider instances generated by RainbowKit can potentially clash with the version of Ethers.js installed alongside wagmi. To avoid this, we’re now relying on theetherspeer dependency that wagmi already requires, ensuring that there's only ever a single copy ofethersbetween them.