feat: add label prop to ConnectButton #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nicoglennon
commented
May 13, 2022
nicoglennon
commented
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
markdalgleish
approved these changes
May 15, 2022
peduarte
reviewed
May 16, 2022
site/data/docs/connect-button.mdx
Outdated
| @@ -59,6 +66,16 @@ The `ConnectButton` component exposes several props to customize its appearance | |||
|
|
|||
| ### Examples | |||
|
|
|||
| #### Label | |||
|
|
|||
| By default your Connect Button will say "Connect Wallet". | |||
There was a problem hiding this comment.
in order to keep the doc copy as minimal as possible, I think we could remove this line since it's already documented in the props table above
site/data/docs/connect-button.mdx
Outdated
|
|
||
| By default your Connect Button will say "Connect Wallet". | ||
|
|
||
| For a custom label, pass your string to the `label` prop. |
There was a problem hiding this comment.
could we use an assertive tone, for consistency with the rest of the docs?
something along the lines of: Use the label prop to set a custom ConnectButton text.
There was a problem hiding this comment.
for sure, sorry i know nothing about this kind of stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.