-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add create-rainbowkit #444
Merged
markdalgleish
merged 12 commits into
main
from
@markdalgleish/RNBW-3582-create-rainbowkit
Jun 2, 2022
Merged
feat: add create-rainbowkit #444
markdalgleish
merged 12 commits into
main
from
@markdalgleish/RNBW-3582-create-rainbowkit
Jun 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nickbytes
reviewed
Jun 1, 2022
: []), | ||
], | ||
[ | ||
alchemyProvider({ alchemyId: '_gg7wSSi0KMBsdKnGVfHDueq6xMB9EkC' }), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if we need to drop a comment that this is a test ID from alchemy?
nickbytes
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm leaving this undocumented for now so that we can trial it out first. If everything looks good once published, we can update the docs to make this more prominent.
Usage (once it's live):
pnpm create @rainbow-me/rainbowkit
(oryarn create
ornpm init
)To test locally, first compile the CLI in watch mode:
Then, in another terminal, run create-rainbowkit and start a dev server against the generated app:
There's more detail provided in the contribution guide.
The generated app is checked in since it's part of the monorepo and needs to be present when running
pnpm install
. The idea is that any changes to the template should also be reflected in updates to the generated test app.Note: I originally tried to gitignore the generated app but found this caused issues with lock file churn since pnpm would remove it from the lock file if the app wasn't present, but this would break CI. By committing the generated app, we avoid forcing everyone to generate the test app themselves all the time, instead only generating it when the template changes and then committing the result.