feat: phantomWallet support #875
Conversation
|
@nheingit is attempting to deploy a commit to the rainbowdotme Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey @jeremygoldbrg 👋🏽 would love a review on this! |
|
hey @chriskalani can you replace the rounded logo svg with a square one please? |
|
hey @mikearndt I've updated the logo — thanks for the quick response! |
|
Hey @mikearndt Just wanted to follow up here to see if there were any blockers to getting this merged? Would love to let dapps downstream add Phantom to their modals. |
|
@nheingit do you all use WalletConnect for your mobile wallet? If so, would you like to add it to the wallet connector here? |
|
@nickbytes We don't have walletconnect support out yet for ETH. We're currently integrated into WalletConnect on the solana side, and we're working with the WC team to see what it looks like for multichain. But nothing is live yet. We can write another PR once we've done the integration work on our end. |
|
@nheingit would you mind adding Phantom to the example application in |
packages/rainbowkit/src/wallets/walletConnectors/phantomWallet/phantomWallet.ts
Show resolved
Hide resolved
|
@nheingit can you fix some linting errors here? |
Only update state and rely on react to fire off reconnect
There was a problem hiding this comment.
Please also migrate DesktopOptions and ConnectDetails changes to a new PR. We can stage them for the same release, but those will need additional auditing and testing. Likely can't proceed with this current implementation and would need more robust changes to ready upstream. The changes may need to be made upstream to Wagmi here
examples/with-next/pages/_app.tsx
Outdated
| @@ -10,6 +10,7 @@ import { | |||
| argentWallet, | |||
| trustWallet, | |||
| ledgerWallet, | |||
| phantomWallet, | |||
There was a problem hiding this comment.
Revert addition to with-next
| @@ -38,6 +39,7 @@ const connectors = connectorsForWallets([ | |||
| omniWallet({ chains }), | |||
| imTokenWallet({ chains }), | |||
| ledgerWallet({ chains }), | |||
| phantomWallet({ chains }), | |||
There was a problem hiding this comment.
Revert addition to site
DanielSinclair
changed the title
Hey Rainbowkit team,
Opening this PR as we have a closed-beta going on right now, and several of the dapps that want to participate use rainbowkit for their modal.
Please let me know if there's anything I can do to support this PR and get it merged.