ncu crashes when root package.json contains workspaces → packages

[kachkaev]

👋 @raineorshine!

• I have searched for similar issues
• I am using the latest version of npm-check-updates (16.3.16)
• I am using node >= 14.14

---

Steps to Reproduce

.ncurc:

n/a

Dependencies:

{
  "workspaces": {
    "packages": ["packages/*"],
    "nohoist": ["**/react-native", "**/react-native/**"]
  }
}

Source: https://classic.yarnpkg.com/blog/2018/02/15/nohoist/

Steps:

1. Run ncu --workspaces

Current Behavior

ncu crashes

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received an instance of Object
    at new NodeError (node:internal/errors:387:5)
    at validateString (node:internal/validators:162:11)
    at Object.join (node:path:1172:7)
    at /Users/ak/.nvm/versions/node/v16.18.0/lib/node_modules/npm-check-updates/build/src/index.js:249:50
    at Array.map (<anonymous>)
    at runUpgrades (/Users/ak/.nvm/versions/node/v16.18.0/lib/node_modules/npm-check-updates/build/src/index.js:249:18) {
  code: 'ERR_INVALID_ARG_TYPE'

Expected Behavior

ncu works for workspaces → packages → [] as for workspaces → []

{
  "workspaces":  ["packages/*"]
}

Relevant code

npm-check-updates/src/index.ts

Lines 220 to 221 in 6aaf11f

	const workspaces = (typeof pkgData === 'string' ? (JSON.parse(pkgData) as PackageFile) : (pkgData as PackageFile))
	.workspaces

npm-check-updates/src/index.ts

Lines 254 to 255 in 6aaf11f

	const workspaces = (typeof pkgData === 'string' ? (JSON.parse(pkgData) as PackageFile) : (pkgData as PackageFile))
	.workspaces

[raineorshine]

Thanks for reporting!

Fixed and published in v16.3.17.

[kachkaev]

Big thanks @raineorshine! I just upgraded npm-check-updates to 16.3.17 and --workspaces worked 🔥